dm/DMTileGridTask.cpp - Issue 89533004: Missed this flag. out/Debug/dm --tileGrid --match imagemagnifier asserts without it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: dm/DMTileGridTask.cpp

Issue 89533004: Missed this flag. out/Debug/dm --tileGrid --match imagemagnifier asserts without it. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #include "DMTileGridTask.h"	1 #include "DMTileGridTask.h"

2 #include "DMWriteTask.h"	2 #include "DMWriteTask.h"

3 #include "DMUtil.h"	3 #include "DMUtil.h"

4	4

5 #include "SkCommandLineFlags.h"	5 #include "SkCommandLineFlags.h"

6 #include "SkPicture.h"	6 #include "SkPicture.h"

7 #include "SkTileGridPicture.h"	7 #include "SkTileGridPicture.h"

8	8

9 // TODO(mtklein): Tile grid tests are currently failing. (Skia issue 1198). Wh en fixed, -> true.	9 // TODO(mtklein): Tile grid tests are currently failing. (Skia issue 1198). Wh en fixed, -> true.

10 DEFINE_bool(tileGrid, false, "If true, run picture replay tests with a tile grid .");	10 DEFINE_bool(tileGrid, false, "If true, run picture replay tests with a tile grid .");

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 if (!BitmapsEqual(full, fReference)) {	64 if (!BitmapsEqual(full, fReference)) {

65 this->fail();	65 this->fail();

66 this->spawnChild(SkNEW_ARGS(WriteTask, (*this, full)));	66 this->spawnChild(SkNEW_ARGS(WriteTask, (*this, full)));

67 }	67 }

68 }	68 }

69	69

70 bool TileGridTask::shouldSkip() const {	70 bool TileGridTask::shouldSkip() const {

71 if (fGM->getFlags() & skiagm::GM::kSkipPicture_Flag) {	71 if (fGM->getFlags() & skiagm::GM::kSkipPicture_Flag) {

72 return true;	72 return true;

73 }	73 }

	74 if (fGM->getFlags() & skiagm::GM::kSkipTiled_Flag) {

	75 return true;

	76 }

74 return !FLAGS_tileGrid;	77 return !FLAGS_tileGrid;

75 }	78 }

76	79

77 } // namespace DM	80 } // namespace DM

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »