Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 895283003: Start moving ownership of SyncNotificationController to SyncController, take 2. (Closed)

Created:
5 years, 10 months ago by maxbogue
Modified:
5 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, mlamouri+watch-notifications_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, peter+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start moving ownership of SyncNotificationController to SyncController, take 2. Original: http://crrev.com/889723002 Reverted: http://crrev.com/895373002 This version restores a missing @VisibleForTests annotation to GoogleServicesNotificationController.getInstance(). Its removal caused the method to be pruned on build, breaking downstream tests that depended on it. GoogleServicesNotificationController is modified to work the way most other singleton classes work, so that it is not necessary to pass into the SyncNotificationController constructor (and thus, into SyncController in the future). SyncController gets a temporary setter method so that SNC can be constructed downstream and passed in until all its dependencies are upstream. BUG=428882 Committed: https://crrev.com/d6674cc202f506329d414a3aeb17dccb26f30bdb Cr-Commit-Position: refs/heads/master@{#315367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -19 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/GoogleServicesNotificationController.java View 4 chunks +22 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
maxbogue
Let's try this again.
5 years, 10 months ago (2015-02-04 18:56:16 UTC) #2
nyquist
lgtm
5 years, 10 months ago (2015-02-05 23:23:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895283003/1
5 years, 10 months ago (2015-02-09 19:38:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 20:01:47 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 20:02:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6674cc202f506329d414a3aeb17dccb26f30bdb
Cr-Commit-Position: refs/heads/master@{#315367}

Powered by Google App Engine
This is Rietveld 408576698