Fix Closure Compilation for chrome://downloads and chrome://history

ui/webui/resources/js/cr/ui/focus_grid.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('cr.ui', function() {
   /**
    * A class to manage grid of focusable elements in a 2D grid. For example,
    * given this grid:
    *
    *   focusable  [focused]  focusable  (row: 0, col: 1)
@@ skipping 25 matching lines @@
     this.eventTracker_.add(cr.doc, 'focusin', this.onFocusin_.bind(this));
 
     /** @private {cr.ui.FocusRow.Delegate} */
     this.delegate_ = new FocusGrid.RowDelegate(this);
   }
 
   /**
    * Row delegate to overwrite the behavior of a mouse click to deselect any row
    * that wasn't clicked.
    * @param {cr.ui.FocusGrid} focusGrid
+   * @constructor
    * @implements {cr.ui.FocusRow.Delegate}
    */
   FocusGrid.RowDelegate = function(focusGrid) {
     /** @private {cr.ui.FocusGrid} */
     this.focusGrid_ = focusGrid;
   };
 
   FocusGrid.RowDelegate.prototype = {
     /** @override */
     onKeydown: function(row, e) { return false; },
 
     /** @override */
     onMousedown: function(row, e) {
       // Only care about left mouse click.
       if (e.button)
         return false;
 
       // Only the clicked row should be active.
       this.focusGrid_.rows.forEach(function(row) {
-        row.makeRowActive(row.contains(e.target));
+        row.makeRowActive(row.contains(/** @type {Node} */ (e.target)));

[Dan Beam, 2015/02/04 17:08:05]

how do you know this is a node?

[hcarmona, 2015/02/04 19:19:55]

Changed casts to assertInstanceof and verified that the functions are listening
to elements instead of document or window.

       });
 
       e.preventDefault();
       return true;
     },
   };
 
   FocusGrid.prototype = {
     /**
      * Unregisters event handlers and removes all |this.rows|.
      */
     destroy: function() {
       this.rows.forEach(function(row) { row.destroy(); });
       this.rows.length = 0;
     },
 
     /**
      * @param {EventTarget} target A target item to find in this grid.
      * @return {number} The row index. -1 if not found.
      */
     getRowIndexForTarget: function(target) {
       for (var i = 0; i < this.rows.length; ++i) {
-        if (this.rows[i].contains(target))
+        if (this.rows[i].contains(/** @type {Node} */ (target)))

[Dan Beam, 2015/02/04 17:08:05]

how do you know this is a node?

[hcarmona, 2015/02/04 19:19:55]

This function doesn't know where it will be called. Updated it so it expects a
node. Also updated where it is called since those functions will know where the
event came from so it can be casted safely.

           return i;
       }
       return -1;
     },
 
     /**
      * Handles keyboard shortcuts to move up/down in the grid.
      * @param {Event} e The key event.
      * @private
      */
@@ skipping 16 matching lines @@
       var rowToFocus = this.rows[row];
       if (rowToFocus) {
         this.ignoreFocusChange_ = true;
         rowToFocus.getEquivalentElement(this.lastFocused).focus();
         e.preventDefault();
       }
     },
 
     /**
      * Keep track of the last column that the user manually focused.
-     * @param {Event} The focusin event.
+     * @param {Event} e The focusin event.
      * @private
      */
     onFocusin_: function(e) {
       if (this.ignoreFocusChange_) {
         this.ignoreFocusChange_ = false;
         return;
       }
 
       if (this.getRowIndexForTarget(e.target) != -1)
         this.lastFocused = e.target;
@@ skipping 23 matching lines @@
 
       // Add the row after its initial focus is set.
       this.rows.push(row);
     },
   };
 
   return {
     FocusGrid: FocusGrid,
   };
 });