Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 895263002: ozone: Add more missing dependencies (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Add more missing dependencies This fixes unresolved references in the linux chromiumos ozone shared_library build. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) Committed: https://crrev.com/a8846480f0b0e99057acb9b05ed2202ce82612af Cr-Commit-Position: refs/heads/master@{#314583}

Patch Set 1 #

Patch Set 2 : more stuff #

Patch Set 3 : also gyp geometry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ui/events/ozone/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/demo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 10 months ago (2015-02-04 01:07:30 UTC) #2
dnicoara
lgtm
5 years, 10 months ago (2015-02-04 03:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895263002/40001
5 years, 10 months ago (2015-02-04 17:34:18 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 18:10:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:11:09 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a8846480f0b0e99057acb9b05ed2202ce82612af
Cr-Commit-Position: refs/heads/master@{#314583}

Powered by Google App Engine
This is Rietveld 408576698