Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 89523002: Move Posix file utils to the base namespace. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, nkostylev+watch_chromium.org, tzik, benjhayden+dwatch_chromium.org, tfarina, browser-components-watch_chromium.org, dcheng, nhiroki, joi+watch-content_chromium.org, eroman, darin-cc_chromium.org, mmenke, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move Posix file utils to the base namespace. BUG= R=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237642

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -437 lines) Patch
M base/base_paths_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 1 3 chunks +14 lines, -15 lines 0 comments Download
M base/file_util_posix.cc View 5 chunks +19 lines, -20 lines 0 comments Download
M base/file_util_unittest.cc View 71 chunks +297 lines, -308 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 12 chunks +14 lines, -14 lines 0 comments Download
M base/linux_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/process/process_handle_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/rand_util_posix.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/sync_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_log_temp_file.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/login_database_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/set_process_title.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/extension_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M sql/connection_unittest.cc View 1 2 3 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
Your last patch gave me the great idea to send this to you (should be ...
7 years ago (2013-11-26 23:06:53 UTC) #1
rvargas (doing something else)
LGTM
7 years ago (2013-11-26 23:54:45 UTC) #2
brettw
7 years ago (2013-11-27 23:22:15 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 manually as r237642.

Powered by Google App Engine
This is Rietveld 408576698