Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 895223002: Update and consolidate Bing Search Provider Info (Closed)

Created:
5 years, 10 months ago by mike.schechter
Modified:
5 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, vasilii+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change removes market specific search provider configuration for Bing. Using a single provider for all markets will allow the Bing server to make the market determination, providing a more consistent user experience regardless of entry point. This will additionally simplify Bing's configuration for any future changes that may be needed. It also adds Bing to markets where it was previously excluded, moves the suggestion URL to https, and updates URL parameters used for reporting purposes. Committed: https://crrev.com/bf6574646d931d5d166a0673faa466778b46665f Cr-Commit-Position: refs/heads/master@{#314787}

Patch Set 1 #

Patch Set 2 : Removing Bing from markets where it did not previously exist #

Patch Set 3 : Fixing accidental duplicate entry for Algeria #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -510 lines) Patch
M components/search_engines/prepopulated_engines.json View 4 chunks +5 lines, -424 lines 0 comments Download
M components/search_engines/template_url_prepopulate_data.cc View 1 2 28 chunks +79 lines, -86 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
mike.schechter
This change intends to simplify the Bing search provider configuration by using a unified provider ...
5 years, 10 months ago (2015-02-04 20:12:17 UTC) #2
Peter Kasting
Please don't add Bing to countries it's not currently in (China, Korea, Netherlands, Russia, Slovenia, ...
5 years, 10 months ago (2015-02-04 20:16:13 UTC) #3
mike.schechter
Thanks - I was unaware of the legal issues. Updated to remove Bing from markets ...
5 years, 10 months ago (2015-02-04 21:01:05 UTC) #4
Peter Kasting
lgtm
5 years, 10 months ago (2015-02-04 21:01:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895223002/20001
5 years, 10 months ago (2015-02-04 21:03:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/55466)
5 years, 10 months ago (2015-02-04 21:25:39 UTC) #9
Peter Kasting
Wow, I'm glad we have a test that catches that!
5 years, 10 months ago (2015-02-05 09:14:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895223002/60001
5 years, 10 months ago (2015-02-05 09:15:39 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-05 10:11:30 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 10:13:18 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf6574646d931d5d166a0673faa466778b46665f
Cr-Commit-Position: refs/heads/master@{#314787}

Powered by Google App Engine
This is Rietveld 408576698