Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/WebCore/inspector/front-end/treeoutline.js

Issue 8952012: Merge 102757 - Web Inspector: TreeOutline's is broken when li elements have padding-left differen... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 980 matching lines...) Expand 10 before | Expand all | Expand 10 after
991 return element; 991 return element;
992 992
993 if (!this.parent || this.parent.root) 993 if (!this.parent || this.parent.root)
994 return null; 994 return null;
995 995
996 return this.parent; 996 return this.parent;
997 } 997 }
998 998
999 TreeElement.prototype.isEventWithinDisclosureTriangle = function(event) 999 TreeElement.prototype.isEventWithinDisclosureTriangle = function(event)
1000 { 1000 {
1001 const leftPadding = 14; 1001 // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446)
1002 var left = this._listItemNode.totalOffsetLeft() + leftPadding; 1002 var computedLeftPadding = window.getComputedStyle(this._listItemNode).getPro pertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);
1003 var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
1003 return event.pageX >= left && event.pageX <= left + this.arrowToggleWidth && this.hasChildren; 1004 return event.pageX >= left && event.pageX <= left + this.arrowToggleWidth && this.hasChildren;
1004 } 1005 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698