Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 895143003: Subzero: Fix unittest build dependencies. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix unittest build dependencies. The unittest .o files also depend on some of the llvm2ice headers, as well as the unittest headers. To reproduce the problem, try this: make -f Makefile.standalone clean make -f Makefile.standalone check-unit 2>/dev/null | grep BitcodeMunge.cpp This will print a line containing BitcodeMunge.cpp. Now do: touch unittest/BitcodeMunge.h make -f Makefile.standalone check-unit 2>/dev/null | grep BitcodeMunge.cpp This should print a line, but it doesn't. Finally: touch src/PNaClTranslator.h make -f Makefile.standalone check-unit 2>/dev/null | grep BitcodeMunge.cpp This should also print a line, but it doesn't. With this patch, the unittest files get rebuilt after header file changes. BUG= none R=jvoung@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6e861d5fe6b3222e8b179962275a57da64e3b825

Patch Set 1 #

Patch Set 2 : Also depend on unittest/*.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Makefile.standalone View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 10 months ago (2015-02-03 21:59:10 UTC) #2
Karl
lgtm
5 years, 10 months ago (2015-02-03 22:00:43 UTC) #3
jvoung (off chromium)
lgtm -- oops!
5 years, 10 months ago (2015-02-03 22:21:37 UTC) #4
Jim Stichnoth
5 years, 10 months ago (2015-02-03 22:35:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6e861d5fe6b3222e8b179962275a57da64e3b825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698