Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895143002: Remove vrk@chromium.org from media OWNERS. (Closed)

Created:
5 years, 10 months ago by xhwang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, vrk (LEFT CHROMIUM)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove vrk@chromium.org from media OWNERS. Thank you for your contributions! TBR=vrk@chromium.org,bemasc@chromium.org Committed: https://crrev.com/d456fb08a91759b669793e1678bf363b8d7133e0 Cr-Commit-Position: refs/heads/master@{#314620}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/hangout_services/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/resources/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/examples/video_decode/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
xhwang
PTAL https://codereview.chromium.org/895143002/diff/1/ppapi/examples/video_decode/OWNERS File ppapi/examples/video_decode/OWNERS (left): https://codereview.chromium.org/895143002/diff/1/ppapi/examples/video_decode/OWNERS#oldcode1 ppapi/examples/video_decode/OWNERS:1: vrk@chromium.org Who should be the new owner?
5 years, 10 months ago (2015-02-03 20:58:35 UTC) #2
scherkus (not reviewing)
lgtm SADFACE :( https://codereview.chromium.org/895143002/diff/1/ppapi/examples/video_decode/OWNERS File ppapi/examples/video_decode/OWNERS (left): https://codereview.chromium.org/895143002/diff/1/ppapi/examples/video_decode/OWNERS#oldcode1 ppapi/examples/video_decode/OWNERS:1: vrk@chromium.org On 2015/02/03 20:58:35, xhwang wrote: ...
5 years, 10 months ago (2015-02-03 21:01:16 UTC) #3
xhwang
comments addressed
5 years, 10 months ago (2015-02-03 21:04:02 UTC) #5
xhwang
bbudge: Added you to be the new OWNER of ppapi/examples/video_decode/. bemasc: You are TBRed for ...
5 years, 10 months ago (2015-02-03 21:08:00 UTC) #9
bbudge
ppapi lgtm
5 years, 10 months ago (2015-02-03 21:09:26 UTC) #10
bemasc
On 2015/02/03 21:09:26, bbudge wrote: > ppapi lgtm hangout_services lgtm
5 years, 10 months ago (2015-02-04 00:36:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895143002/20001
5 years, 10 months ago (2015-02-04 16:50:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/22853)
5 years, 10 months ago (2015-02-04 18:36:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895143002/20001
5 years, 10 months ago (2015-02-04 19:31:01 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 20:15:20 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:17:39 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d456fb08a91759b669793e1678bf363b8d7133e0
Cr-Commit-Position: refs/heads/master@{#314620}

Powered by Google App Engine
This is Rietveld 408576698