sdk/lib/_internal/compiler/js_lib/js_helper.dart - Issue 895083002: Support tearoffs in the new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_helper.dart

Issue 895083002: Support tearoffs in the new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart ('K') | « pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/js_lib/js_helper.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_helper.dart b/sdk/lib/_internal/compiler/js_lib/js_helper.dart

index dd7f4dc27e6cc0e9857ca4a82f522cec1e7c75ab..af144917367cddae518a4f6fdd3db9f15a6b41e7 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_helper.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_helper.dart

@@ -1963,7 +1963,7 @@ abstract class Closure implements Function {

static fromTearOff(receiver,

List functions,

- List reflectionInfo,

+ var reflectionInfo,

floitsch 2015/02/03 19:40:02 Add comments to the function with the information

herhut 2015/02/03 21:18:58 Done.

bool isStatic,

jsArguments,

String propertyName) {

@@ -1977,10 +1977,15 @@ abstract class Closure implements Function {

String name = JS('String|Null', '#.\$stubName', function);

String callName = JS('String|Null', '#.\$callName', function);

- JS('', '#.\$reflectionInfo = #', function, reflectionInfo);

- ReflectionInfo info = new ReflectionInfo(function);

+ var functionType;

+ if (reflectionInfo is List) {

+ JS('', '#.\$reflectionInfo = #', function, reflectionInfo);

+ ReflectionInfo info = new ReflectionInfo(function);

+ functionType = info.functionType;

+ } else {

+ functionType = reflectionInfo;

+ }

- var functionType = info.functionType;

// function tmp() {};

// tmp.prototype = BC.prototype;

@@ -2322,7 +2327,8 @@ closureFromTearOff(receiver,

return Closure.fromTearOff(

receiver,

JSArray.markFixedList(functions),

- JSArray.markFixedList(reflectionInfo),

+ reflectionInfo is List ? JSArray.markFixedList(reflectionInfo)

+ : reflectionInfo,

JS('bool', '!!#', isStatic),

jsArguments,

JS('String', '#', name));