Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 895053002: Move the contents of api-natives.js to c++ (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move the contents of api-natives.js to c++ R=verwaest@chromium.org BUG= Committed: https://crrev.com/8064582626f4f2e012352750fda839ae3f975127 Cr-Commit-Position: refs/heads/master@{#26426}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : build.gn #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Total comments: 6

Patch Set 17 : #

Patch Set 18 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -589 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +2 lines, -2 lines 0 comments Download
M include/v8.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -2 lines 0 comments Download
A src/api-natives.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A src/api-natives.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +529 lines, -0 lines 0 comments Download
M src/apinatives.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -119 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 6 chunks +10 lines, -13 lines 0 comments Download
M src/builtins.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/contexts.h View 1 2 3 4 5 3 chunks +1 line, -5 lines 0 comments Download
M src/date.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -0 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M src/factory.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M src/factory.cc View 1 2 2 chunks +0 lines, -195 lines 0 comments Download
M src/macros.py View 2 chunks +0 lines, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +0 lines, -5 lines 0 comments Download
D src/runtime/runtime-api.cc View 1 1 chunk +0 lines, -127 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcarney
ptal
5 years, 10 months ago (2015-02-04 10:49:03 UTC) #2
dcarney
ptal
5 years, 10 months ago (2015-02-04 10:49:25 UTC) #4
Toon Verwaest
Very nice cleanup. lgtm with minor comments https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc File src/api-natives.cc (right): https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode133 src/api-natives.cc:133: // standard. ...
5 years, 10 months ago (2015-02-04 12:04:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895053002/340001
5 years, 10 months ago (2015-02-04 12:40:05 UTC) #8
commit-bot: I haz the power
Committed patchset #18 (id:340001)
5 years, 10 months ago (2015-02-04 13:01:41 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 13:01:56 UTC) #10
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/8064582626f4f2e012352750fda839ae3f975127
Cr-Commit-Position: refs/heads/master@{#26426}

Powered by Google App Engine
This is Rietveld 408576698