Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 895013002: Revert of Move the call to CRYPTO_set_NEON_capable up. (Closed)

Created:
5 years, 10 months ago by Noel Gordon
Modified:
5 years, 10 months ago
Reviewers:
agl, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move the call to CRYPTO_set_NEON_capable up. (patchset #1 id:1 of https://codereview.chromium.org/899463002/) Reason for revert: Suspect this change upset the webkit ChromeOS Test 1, Mac 10.8, encrypted media tests. Reverting to see if these builders turn green. http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/9563 Original issue's description: > Move the call to CRYPTO_set_NEON_capable up. > > BoringSSL needs to probe for NEON support via SIGILL in cases where > getauxval isn't provided and the application doesn't do explicit > initialisation. > > However, Chromium might have gone multithreaded by the time that we > initialise BoringSSL and, although it doesn't look like we'll race the > disposition of SIGILL with anything, it's best not to test that hope. > > So this change causes CRYPTO_set_NEON_capable to always be called, and > to be called before SSL_library_init. BoringSSL will take that as a > signal that probing for NEON support isn't needed. > > BUG=none > > Committed: https://crrev.com/fa9063829e638aeb72ede79e5d0396a81a0211d1 > Cr-Commit-Position: refs/heads/master@{#314201} TBR=davidben@chromium.org,agl@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/02f7bf1302c3e613b887fbb3f46dd54f5f5888d3 Cr-Commit-Position: refs/heads/master@{#314301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M crypto/openssl_util.cc View 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Noel Gordon
Created Revert of Move the call to CRYPTO_set_NEON_capable up.
5 years, 10 months ago (2015-02-03 09:54:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895013002/1
5 years, 10 months ago (2015-02-03 09:54:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 09:55:55 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 09:58:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02f7bf1302c3e613b887fbb3f46dd54f5f5888d3
Cr-Commit-Position: refs/heads/master@{#314301}

Powered by Google App Engine
This is Rietveld 408576698