content/browser/service_worker/service_worker_registration.h - Issue 894973003: ServiceWorker: Make "ready" fetches registration from browser process(2/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 894973003: ServiceWorker: Make "ready" fetches registration from browser process(2/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: work around push browser tests; make ready IPC sent later Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/push_messaging/push_test.js ('K') | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_registration.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.h

diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h

index 768b6519d02e4cc4a70d883f857f5269c1b8be82..c6ecbf8aa84909b919827a53d330f486a1c96828 100644

--- a/content/browser/service_worker/service_worker_registration.h

+++ b/content/browser/service_worker/service_worker_registration.h

@@ -42,9 +42,12 @@ class CONTENT_EXPORT ServiceWorkerRegistration

const ServiceWorkerRegistrationInfo& info) {}

virtual void OnRegistrationFailed(

ServiceWorkerRegistration* registration) {}

+ virtual void OnRegistrationFinishedUninstalling(

+ ServiceWorkerRegistration* registration) {}

virtual void OnUpdateFound(

ServiceWorkerRegistration* registration) {}

virtual void OnSkippedWaiting(ServiceWorkerRegistration* registation) {}

+ virtual void OnActivateVersion(ServiceWorkerRegistration* registration) {}

falken 2015/03/05 09:21:52 It's kind of bizarre to have both OnVersionAttribu

};

ServiceWorkerRegistration(const GURL& pattern,