Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 894973003: ServiceWorker: Make "ready" fetches registration from browser process(2/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: #13 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration.cc
diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc
index 0ccc2e40341d11a9da3e70b6527615385cf314ca..51504fe36536b4ef5a4ac31fd4e9dc07afc5380e 100644
--- a/content/browser/service_worker/service_worker_registration.cc
+++ b/content/browser/service_worker/service_worker_registration.cc
@@ -303,10 +303,12 @@ void ServiceWorkerRegistration::OnActivateEventFinished(
id(), pattern().GetOrigin(),
base::Bind(&ServiceWorkerRegistration::OnDeleteFinished, this));
// But not from memory if there is a version in the pipeline.
- if (installing_version())
+ if (installing_version()) {
is_deleted_ = false;
- else
+ } else {
is_uninstalled_ = true;
+ FOR_EACH_OBSERVER(Listener, listeners_, OnRegistrationFailed(this));
+ }
}
return;
}
@@ -355,6 +357,9 @@ void ServiceWorkerRegistration::Clear() {
FOR_EACH_OBSERVER(Listener, listeners_,
OnVersionAttributesChanged(this, mask, info));
}
+
+ FOR_EACH_OBSERVER(
+ Listener, listeners_, OnRegistrationFinishedUninstalling(this));
}
void ServiceWorkerRegistration::OnRestoreFinished(

Powered by Google App Engine
This is Rietveld 408576698