Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 894913006: Deletes the now-unused addTrace methods that don't accept user-supplied timestamps. (Closed)

Created:
5 years, 10 months ago by charliea
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, sullivan, nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deletes the now-unused addTrace methods that don't accept user-supplied timestamps. Follow-up to http://crrev.com/870053006 (which added the methods that accept user-supplied timestamps) and http://crrev.com/892463004 (which modified Blink to use the user-supplied timestamps). BUG=345845 Committed: https://crrev.com/aafbad78096f681d9677df4134e333dc3e11a90e Cr-Commit-Position: refs/heads/master@{#315215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -23 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
charliea_google.com
5 years, 10 months ago (2015-02-03 23:59:56 UTC) #2
jam
lgtm
5 years, 10 months ago (2015-02-04 16:35:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894913006/1
5 years, 10 months ago (2015-02-04 16:36:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/39298)
5 years, 10 months ago (2015-02-04 16:44:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894913006/1
5 years, 10 months ago (2015-02-07 20:36:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 21:35:29 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 21:36:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aafbad78096f681d9677df4134e333dc3e11a90e
Cr-Commit-Position: refs/heads/master@{#315215}

Powered by Google App Engine
This is Rietveld 408576698