Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) | 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) |
| 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) | 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) |
| 4 * (C) 2001 Dirk Mueller (mueller@kde.org) | 4 * (C) 2001 Dirk Mueller (mueller@kde.org) |
| 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. | 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. |
| 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) | 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) |
| 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) | 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) |
| 8 * Copyright (C) 2011 Google Inc. All rights reserved. | 8 * Copyright (C) 2011 Google Inc. All rights reserved. |
| 9 * | 9 * |
| 10 * This library is free software; you can redistribute it and/or | 10 * This library is free software; you can redistribute it and/or |
| (...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 199 m_event->setTarget(EventPath::eventTargetRespectingTargetRules(*m_node)); | 199 m_event->setTarget(EventPath::eventTargetRespectingTargetRules(*m_node)); |
| 200 m_event->setCurrentTarget(0); | 200 m_event->setCurrentTarget(0); |
| 201 m_event->setEventPhase(0); | 201 m_event->setEventPhase(0); |
| 202 | 202 |
| 203 // Pass the data from the preDispatchEventHandler to the postDispatchEventHa ndler. | 203 // Pass the data from the preDispatchEventHandler to the postDispatchEventHa ndler. |
| 204 m_node->postDispatchEventHandler(m_event.get(), preDispatchEventHandlerResul t); | 204 m_node->postDispatchEventHandler(m_event.get(), preDispatchEventHandlerResul t); |
| 205 | 205 |
| 206 // Call default event handlers. While the DOM does have a concept of prevent ing | 206 // Call default event handlers. While the DOM does have a concept of prevent ing |
| 207 // default handling, the detail of which handlers are called is an internal | 207 // default handling, the detail of which handlers are called is an internal |
| 208 // implementation detail and not part of the DOM. | 208 // implementation detail and not part of the DOM. |
| 209 if (!m_event->defaultPrevented() && !m_event->defaultHandled()) { | 209 |
| 210 // Prevent calling default handlers for synthetic mouse events (issue #42397 5) | |
|
Rick Byers
2015/03/05 16:34:18
Rather than say what the code is doing, this comme
| |
| 211 bool isSyntheticMouseEventOtherThanClick = m_event->isMouseEvent() && toMous eEvent(*m_event).isSynthetic() && toMouseEvent(*m_event).type() != EventTypeName s::click; | |
| 212 | |
| 213 if (!m_event->defaultPrevented() && !m_event->defaultHandled() && !isSynthet icMouseEventOtherThanClick) { | |
| 210 // Non-bubbling events call only one default event handler, the one for the target. | 214 // Non-bubbling events call only one default event handler, the one for the target. |
| 211 m_node->willCallDefaultEventHandler(*m_event); | 215 m_node->willCallDefaultEventHandler(*m_event); |
| 212 m_node->defaultEventHandler(m_event.get()); | 216 m_node->defaultEventHandler(m_event.get()); |
| 213 ASSERT(!m_event->defaultPrevented()); | 217 ASSERT(!m_event->defaultPrevented()); |
| 214 if (m_event->defaultHandled()) | 218 if (m_event->defaultHandled()) |
| 215 return; | 219 return; |
| 216 // For bubbling events, call default event handlers on the same targets in the | 220 // For bubbling events, call default event handlers on the same targets in the |
| 217 // same order as the bubbling phase. | 221 // same order as the bubbling phase. |
| 218 if (m_event->bubbles()) { | 222 if (m_event->bubbles()) { |
| 219 size_t size = m_event->eventPath().size(); | 223 size_t size = m_event->eventPath().size(); |
| 220 for (size_t i = 1; i < size; ++i) { | 224 for (size_t i = 1; i < size; ++i) { |
| 221 m_event->eventPath()[i].node()->willCallDefaultEventHandler(*m_e vent); | 225 m_event->eventPath()[i].node()->willCallDefaultEventHandler(*m_e vent); |
| 222 m_event->eventPath()[i].node()->defaultEventHandler(m_event.get( )); | 226 m_event->eventPath()[i].node()->defaultEventHandler(m_event.get( )); |
| 223 ASSERT(!m_event->defaultPrevented()); | 227 ASSERT(!m_event->defaultPrevented()); |
| 224 if (m_event->defaultHandled()) | 228 if (m_event->defaultHandled()) |
| 225 return; | 229 return; |
| 226 } | 230 } |
| 227 } | 231 } |
| 228 } | 232 } |
| 229 } | 233 } |
| 230 | 234 |
| 231 } | 235 } |
| OLD | NEW |