Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Source/core/events/EventDispatcher.cpp

Issue 894913002: Prevent default actions for JS-generated mouse events other than click (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: TIL, gclient sync may rebase changes back in time Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/events/MouseEvent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2011 Google Inc. All rights reserved. 8 * Copyright (C) 2011 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 m_event->setTarget(EventPath::eventTargetRespectingTargetRules(*m_node)); 199 m_event->setTarget(EventPath::eventTargetRespectingTargetRules(*m_node));
200 m_event->setCurrentTarget(0); 200 m_event->setCurrentTarget(0);
201 m_event->setEventPhase(0); 201 m_event->setEventPhase(0);
202 202
203 // Pass the data from the preDispatchEventHandler to the postDispatchEventHa ndler. 203 // Pass the data from the preDispatchEventHandler to the postDispatchEventHa ndler.
204 m_node->postDispatchEventHandler(m_event.get(), preDispatchEventHandlerResul t); 204 m_node->postDispatchEventHandler(m_event.get(), preDispatchEventHandlerResul t);
205 205
206 // Call default event handlers. While the DOM does have a concept of prevent ing 206 // Call default event handlers. While the DOM does have a concept of prevent ing
207 // default handling, the detail of which handlers are called is an internal 207 // default handling, the detail of which handlers are called is an internal
208 // implementation detail and not part of the DOM. 208 // implementation detail and not part of the DOM.
209 if (!m_event->defaultPrevented() && !m_event->defaultHandled()) { 209
210 // The DOM Events spec says that events dispatched by JS (other than "click" )
211 // should not have their default handlers invoked. (issue #423975)
212 // To begin with, only apply to mouse events.
213 bool isScriptedMouseEventOtherThanClick = m_event->isMouseEvent() && toMouse Event(*m_event).fromScript() && toMouseEvent(*m_event).type() != EventTypeNames: :click;
214
215 if (!m_event->defaultPrevented() && !m_event->defaultHandled() && !isScripte dMouseEventOtherThanClick) {
210 // Non-bubbling events call only one default event handler, the one for the target. 216 // Non-bubbling events call only one default event handler, the one for the target.
211 m_node->willCallDefaultEventHandler(*m_event); 217 m_node->willCallDefaultEventHandler(*m_event);
212 m_node->defaultEventHandler(m_event.get()); 218 m_node->defaultEventHandler(m_event.get());
213 ASSERT(!m_event->defaultPrevented()); 219 ASSERT(!m_event->defaultPrevented());
214 if (m_event->defaultHandled()) 220 if (m_event->defaultHandled())
215 return; 221 return;
216 // For bubbling events, call default event handlers on the same targets in the 222 // For bubbling events, call default event handlers on the same targets in the
217 // same order as the bubbling phase. 223 // same order as the bubbling phase.
218 if (m_event->bubbles()) { 224 if (m_event->bubbles()) {
219 size_t size = m_event->eventPath().size(); 225 size_t size = m_event->eventPath().size();
220 for (size_t i = 1; i < size; ++i) { 226 for (size_t i = 1; i < size; ++i) {
221 m_event->eventPath()[i].node()->willCallDefaultEventHandler(*m_e vent); 227 m_event->eventPath()[i].node()->willCallDefaultEventHandler(*m_e vent);
222 m_event->eventPath()[i].node()->defaultEventHandler(m_event.get( )); 228 m_event->eventPath()[i].node()->defaultEventHandler(m_event.get( ));
223 ASSERT(!m_event->defaultPrevented()); 229 ASSERT(!m_event->defaultPrevented());
224 if (m_event->defaultHandled()) 230 if (m_event->defaultHandled())
225 return; 231 return;
226 } 232 }
227 } 233 }
228 } 234 }
229 } 235 }
230 236
231 } 237 }
OLDNEW
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/events/MouseEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698