Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 894903004: Adding instrumentation to locate the source of jankiness. (Closed)

Created:
5 years, 10 months ago by Peter Kasting
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, erikwright (departed)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding instrumentation to locate the source of jankiness. Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. BUG=456327, 456331, 456373 TEST=none TBR=mmenke, erikwright Committed: https://crrev.com/b60049a86e45b0160f378624c5dfd99d667c5262 Cr-Commit-Position: refs/heads/master@{#315173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 9 chunks +37 lines, -0 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/cookies/cookie_monster.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 4 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
TBRing for mechanical changes: erikwright: content/browser/net/ OWNERS mmenke: rest
5 years, 10 months ago (2015-02-07 00:44:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894903004/1
5 years, 10 months ago (2015-02-07 01:16:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 03:25:34 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 03:26:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b60049a86e45b0160f378624c5dfd99d667c5262
Cr-Commit-Position: refs/heads/master@{#315173}

Powered by Google App Engine
This is Rietveld 408576698