Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 894883003: Files.app: Add ContentMetadataProvider class. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add ContentMetadataProvider class. It provides metadata obtained from the content in SharedWorker. BUG=410766 TEST=FileManagerJsTest.ContentMetadataProvider Committed: https://crrev.com/ed42610fca4e196ae4a3c26c29f5dcfbaaa68231 Cr-Commit-Position: refs/heads/master@{#314512}

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : Rebased. #

Messages

Total messages: 10 (3 generated)
hirono
PTAL, thanks! Almost all lines are copied from ContentProvider in metadata_cache.js. I changed the following ...
5 years, 10 months ago (2015-02-04 04:38:31 UTC) #2
yawano
https://codereview.chromium.org/894883003/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js File ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js (right): https://codereview.chromium.org/894883003/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js#newcode14 ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js:14: * @param {!MetadataProviderCache<!ContentMetadata>} cache MetadataCacheSet does not have template ...
5 years, 10 months ago (2015-02-04 05:12:11 UTC) #3
hirono
https://codereview.chromium.org/894883003/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js File ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js (right): https://codereview.chromium.org/894883003/diff/20001/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js#newcode14 ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js:14: * @param {!MetadataProviderCache<!ContentMetadata>} cache On 2015/02/04 05:12:11, yawano wrote: ...
5 years, 10 months ago (2015-02-04 05:38:40 UTC) #4
yawano
lgtm.
5 years, 10 months ago (2015-02-04 05:48:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894883003/60001
5 years, 10 months ago (2015-02-04 06:06:28 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-04 06:40:48 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 06:42:00 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ed42610fca4e196ae4a3c26c29f5dcfbaaa68231
Cr-Commit-Position: refs/heads/master@{#314512}

Powered by Google App Engine
This is Rietveld 408576698