Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 894873004: Fix crash on BLU Life Play devices related to switch preferences. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash on BLU Life Play devices related to switch preferences. ChromeSwitchPreference uses setWidgetLayoutResource() to show a Material switch, but on BLU Life Play devices, this has no effect and the default switch is shown instead. As a result ChromeSwitchPreference.onBindView() couldn't find the Material switch and was crashing with a NPE. This fixes the crash by adding a null check, though these devices will still show a non-material switch. BUG=451447 R=dtrainor@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeSwitchPreference.java View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
newt (away)
5 years, 10 months ago (2015-02-02 23:56:58 UTC) #2
newt (away)
On 2015/02/02 23:56:58, newt wrote: PTAL
5 years, 10 months ago (2015-02-02 23:57:03 UTC) #3
David Trainor- moved to gerrit
lgtm
5 years, 10 months ago (2015-02-03 00:16:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894873004/1
5 years, 10 months ago (2015-02-03 00:31:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 02:32:50 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/796a0bc0a3064f17357460187a02d7b216853e0d Cr-Commit-Position: refs/heads/master@{#314250}
5 years, 10 months ago (2015-02-03 02:41:29 UTC) #9
newt (away)
5 years, 10 months ago (2015-02-03 02:41:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
361ff6c4c5d5fe27bf415eafbfe5cb849bc66712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698