Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 894873002: Don't run whispernet client tests if Nacl is disabled. (Closed)

Created:
5 years, 10 months ago by rkc
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run whispernet client tests if Nacl is disabled. R=ckehoe@chromium.org, timurrrr@chromium.org BUG=449198 Committed: https://crrev.com/8ba6c0709815e5cfd0b32c0127fc7e5c06d90fe4 Cr-Commit-Position: refs/heads/master@{#314365}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 1 1 chunk +23 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rkc
5 years, 10 months ago (2015-02-02 22:17:21 UTC) #1
Charlie
LGTM % comment https://codereview.chromium.org/894873002/diff/1/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (right): https://codereview.chromium.org/894873002/diff/1/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc#newcode180 chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:180: #if !defined(DISABLE_NACL) Too many negatives. Use ...
5 years, 10 months ago (2015-02-02 22:21:53 UTC) #2
rkc
https://codereview.chromium.org/894873002/diff/1/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (right): https://codereview.chromium.org/894873002/diff/1/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc#newcode180 chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:180: #if !defined(DISABLE_NACL) On 2015/02/02 22:21:52, Charlie wrote: > Too ...
5 years, 10 months ago (2015-02-03 17:30:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894873002/20001
5 years, 10 months ago (2015-02-03 17:31:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 18:07:59 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 18:09:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ba6c0709815e5cfd0b32c0127fc7e5c06d90fe4
Cr-Commit-Position: refs/heads/master@{#314365}

Powered by Google App Engine
This is Rietveld 408576698