Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 894863003: Suppress another FontConfig 'leak'. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Suppress another FontConfig 'leak'. FontConfig uses offsets for elements instead of pointers, so any value held by an element goes missing from memory checkers. Previous suppressions took care of rule copies and adds to elements, but value lists may be copied as well. When they are, values are copied, including the content of strings and matricies. Since value lists are effectively like Fc*Add functions (even calling the same underlying helpers), treat them as such and suppress any 'leaks' they may cause. Committed: https://skia.googlesource.com/skia/+/8d9225ba78c05194fdffc05ee8bdd5c15b7367ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/valgrind.supp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
Proposed alternate to https://codereview.chromium.org/897953006/ . This allows us to still track the actual pointer returned ...
5 years, 10 months ago (2015-02-05 17:00:57 UTC) #2
mtklein
lgtm lgtm, thanks, got distracted.
5 years, 10 months ago (2015-02-05 17:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894863003/1
5 years, 10 months ago (2015-02-05 17:05:53 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 17:11:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8d9225ba78c05194fdffc05ee8bdd5c15b7367ff

Powered by Google App Engine
This is Rietveld 408576698