Add a script to print js closure-style dependencies.

Add a script to print js closure-style dependencies.

ChromeVox uses Google closure-style dependencies (goog.provide and
goog.require) and this script gives a quick view of the dependency tree for
a module.

R=dtseng@chromium.org
BUG=none

Committed: https://crrev.com/eddcdbd9a9930fdee5639735bc644584a36e50e1
Cr-Commit-Position: refs/heads/master@{#314565}

[dmazzoni, 2015-02-03 16:20:42]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-02-03 16:20:43]

lgtm

Neat, seems really useful!

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py (right):

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:9: Given one
or more roots, specified by -r options and one top-level file,
Is it necessary to specify one root or is the root of the required top level
file implied?

Also, would it make sense to set the roots to the current cvox directories by
default, but allow them to be overridden? It seems like most of them time we'd
want the same roots, or maybe one set for cvox and one set for cvox2 - are there
any other reasons to manually specify them?

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:11: A module
is only expanded once; on a second encoutner, its dependencies
nit: encoutner -> encounter

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:66:
Die('Exactly one top-level source file must be specified.')
How about parser.print_help() also?

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:69:
source_files=[start_path])
nit: indentation

[David Tseng, 2015-02-03 18:16:11]

lgtm

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py (right):

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:9: Given one
or more roots, specified by -r options and one top-level file,
On 2015/02/03 16:20:43, dmazzoni wrote:
> Is it necessary to specify one root or is the root of the required top level
> file implied?
> 
> Also, would it make sense to set the roots to the current cvox directories by
> default, but allow them to be overridden? It seems like most of them time we'd
> want the same roots, or maybe one set for cvox and one set for cvox2 - are
there
> any other reasons to manually specify them?

I think root here refers to directories to recursively scan for js files.

[David Tseng, 2015-02-03 18:22:27]

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py (right):

https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:9: Given one
or more roots, specified by -r options and one top-level file,
On 2015/02/03 18:16:11, David Tseng wrote:
> On 2015/02/03 16:20:43, dmazzoni wrote:
> > Is it necessary to specify one root or is the root of the required top level
> > file implied?
> > 
> > Also, would it make sense to set the roots to the current cvox directories
by
> > default, but allow them to be overridden? It seems like most of them time
we'd
> > want the same roots, or maybe one set for cvox and one set for cvox2 - are
> there
> > any other reasons to manually specify them?
> 
> I think root here refers to directories to recursively scan for js files.

Meant to say: Closure we need both Closure and ChromeVox roots. A friendlier
default including these would be great.

[Peter Lundblad, 2015-02-04 15:05:21]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2015-02-04 15:06:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894853006/20001

[Peter Lundblad, 2015-02-04 15:09:05]

dmazzoni@chromium.org writes:
> lgtm
> 
> Neat, seems really useful!
> 
> 
>
https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py
> (right):
> 
>
https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:9:
> Given one or more roots, specified by -r options and one top-level file,
> Is it necessary to specify one root or is the root of the required top
> level file implied?

As David said, this is directory trees.


> Also, would it make sense to set the roots to the current cvox
> directories by default, but allow them to be overridden? It seems like
> most of them time we'd want the same roots, or maybe one set for cvox
> and one set for cvox2 - are there any other reasons to manually specify
> them?

Good idea, made the closure and chromevox directories the default.

>
https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:11: A
> module is only expanded once; on a second encoutner, its dependencies
> nit: encoutner -> encounter

Done.

>
https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:66:
> Die('Exactly one top-level source file must be specified.')
> How about parser.print_help() also?

I find that annoying because you have too look through the help to
find the error, but I can see this is a matter of preference.
Left as is.

>
https://codereview.chromium.org/894853006/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/tools/print_js_deps.py:69:
> source_files=[start_path])
> nit: indentation

Done.

> https://codereview.chromium.org/894853006/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-02-04 15:51:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-04 15:52:19]

Patchset 2 (id:??) landed as
https://crrev.com/eddcdbd9a9930fdee5639735bc644584a36e50e1
Cr-Commit-Position: refs/heads/master@{#314565}