Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: content/browser/frame_host/frame_tree.cc

Issue 894843003: Move the RenderProcessGone IPC from RenderViewHost to RenderFrameHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree.h" 5 #include "content/browser/frame_host/frame_tree.h"
6 6
7 #include <queue> 7 #include <queue>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 render_frame_host->render_view_host()->GetSiteInstance(); 303 render_frame_host->render_view_host()->GetSiteInstance();
304 RenderViewHostMap::iterator iter = 304 RenderViewHostMap::iterator iter =
305 render_view_host_map_.find(site_instance->GetId()); 305 render_view_host_map_.find(site_instance->GetId());
306 CHECK(iter != render_view_host_map_.end()); 306 CHECK(iter != render_view_host_map_.end());
307 307
308 iter->second->increment_ref_count(); 308 iter->second->increment_ref_count();
309 } 309 }
310 310
311 void FrameTree::UnregisterRenderFrameHost( 311 void FrameTree::UnregisterRenderFrameHost(
312 RenderFrameHostImpl* render_frame_host) { 312 RenderFrameHostImpl* render_frame_host) {
313 SiteInstance* site_instance = 313 SiteInstance* site_instance = render_frame_host->GetSiteInstance();
314 render_frame_host->render_view_host()->GetSiteInstance();
Charlie Reis 2015/02/03 01:06:35 Is this unrelated? We should probably do GetSiteI
nasko 2015/02/04 16:51:31 Done.
315 int32 site_instance_id = site_instance->GetId(); 314 int32 site_instance_id = site_instance->GetId();
316 RenderViewHostMap::iterator iter = 315 RenderViewHostMap::iterator iter =
317 render_view_host_map_.find(site_instance_id); 316 render_view_host_map_.find(site_instance_id);
318 if (iter != render_view_host_map_.end() && 317 if (iter != render_view_host_map_.end() &&
319 iter->second == render_frame_host->render_view_host()) { 318 iter->second == render_frame_host->render_view_host()) {
320 // Decrement the refcount and shutdown the RenderViewHost if no one else is 319 // Decrement the refcount and shutdown the RenderViewHost if no one else is
321 // using it. 320 // using it.
322 CHECK_GT(iter->second->ref_count(), 0); 321 CHECK_GT(iter->second->ref_count(), 0);
323 iter->second->decrement_ref_count(); 322 iter->second->decrement_ref_count();
324 if (iter->second->ref_count() == 0) { 323 if (iter->second->ref_count() == 0) {
(...skipping 22 matching lines...) Expand all
347 rvh->Shutdown(); 346 rvh->Shutdown();
348 render_view_host_pending_shutdown_map_.erase(multi_iter); 347 render_view_host_pending_shutdown_map_.erase(multi_iter);
349 } 348 }
350 break; 349 break;
351 } 350 }
352 CHECK(render_view_host_found); 351 CHECK(render_view_host_found);
353 } 352 }
354 } 353 }
355 354
356 } // namespace content 355 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698