Issue 894843002: Remove a site-per-process hack that is no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 894843002: Remove a site-per-process hack that is no longer needed. (Closed)

Created:
5 years, 10 months ago by Avi (use Gerrit)

Modified:
5 years, 10 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove a site-per-process hack that is no longer needed. BUG=314791 TEST=things stay green

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	content/browser/frame_host/navigator_impl.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Avi (use Gerrit)

As noted in https://codereview.chromium.org/839413004/, the test NavigationControllerBrowserTest.ManualAndAutoSubframeNavigationClassification passes in site-per-process with this gone. Given the ...

5 years, 10 months ago (2015-02-02 21:18:31 UTC) #2

Charlie Reis

We can't land this without the render_frame_impl.cc changes you made in https://codereview.chromium.org/839413004/. (It's not obsolete ...

5 years, 10 months ago (2015-02-02 21:33:30 UTC) #3

Avi (use Gerrit)

5 years, 10 months ago (2015-02-02 22:05:57 UTC) #4

On 2015/02/02 21:33:30, Charlie Reis wrote:
> We can't land this without the render_frame_impl.cc changes you made in
> https://codereview.chromium.org/839413004/.  (It's not obsolete until then.)

Closing this CL then.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages