Issue 894833002: Add missing SK_OVERRIDE

Issue 894833002: Add missing SK_OVERRIDE (Closed)

Created:
5 years, 10 months ago by rmistry

Modified:
5 years, 10 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Add missing SK_OVERRIDE Tested by running on clang head + ubuntu 14.04: GYP_DEFINES=”skia_gpu=0 skia_warnings_as_errors=1" tools/xsan_build thread dm BUILDTYPE=Release out/Release/dm -v BUG=skia:3386 Committed: https://skia.googlesource.com/skia/+/465206af184f58e8097e7f4f414b791232627c31

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	gm/cmykjpeg.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/colorfilters.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/colortypexfermode.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/dftext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/drawlooper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/factory.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/hairmodes.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/imagefilterscropped.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ports/SkImageGenerator_skia.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PictureTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894833002/1

5 years, 10 months ago (2015-02-02 20:02:31 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-02 20:08:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/465206af184f58e8097e7f4f414b791232627c31