Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 894783002: Remove obsolete code (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup-includes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete code ChromeHistoryClient is no longer a HistoryServiceObserver, so remove the cleanup code that dealt with that. Fix error path when HistoryService::Init() fails in TestingProfile by: - not calling SetTestingFactoryAndUse() with a null testing factory - returning false when HistoryService::Init() fails. BUG=373326 Committed: https://crrev.com/f29a43975907fd816dbdfaeb5c0a595a2e1eef17 Cr-Commit-Position: refs/heads/master@{#314385}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/test/base/testing_profile.cc View 1 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sdefresne
5 years, 10 months ago (2015-02-02 18:19:04 UTC) #1
Jay Civelli
lgtm
5 years, 10 months ago (2015-02-03 18:06:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894783002/1
5 years, 10 months ago (2015-02-03 18:10:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/54912) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/6854) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-02-03 18:12:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894783002/20001
5 years, 10 months ago (2015-02-03 18:55:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 19:41:01 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:42:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f29a43975907fd816dbdfaeb5c0a595a2e1eef17
Cr-Commit-Position: refs/heads/master@{#314385}

Powered by Google App Engine
This is Rietveld 408576698