Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 894773002: Build in C++11 mode on Macs. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Build in C++11 mode on Macs. Build trybots are not triggering. NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/65fd599e43247e139bc3e7afaff9392073fec1bc

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/libwebp.gyp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
mtklein
5 years, 10 months ago (2015-02-02 18:51:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894773002/1
5 years, 10 months ago (2015-02-03 19:36:54 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-03 19:36:55 UTC) #6
mtklein
I think we can try this now that the 10.6 and 10.7 bots are gone. ...
5 years, 10 months ago (2015-02-03 19:41:44 UTC) #7
bungeman-skia
If the strategy is to remove bots until it works, lgtm. Would be nice to ...
5 years, 10 months ago (2015-02-03 19:45:53 UTC) #8
mtklein
On 2015/02/03 19:45:53, bungeman1 wrote: > If the strategy is to remove bots until it ...
5 years, 10 months ago (2015-02-03 19:49:44 UTC) #9
mtklein
On 2015/02/03 19:49:44, mtklein wrote: > On 2015/02/03 19:45:53, bungeman1 wrote: > > If the ...
5 years, 10 months ago (2015-02-03 19:50:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894773002/1
5 years, 10 months ago (2015-02-03 20:28:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894773002/40001
5 years, 10 months ago (2015-02-03 20:30:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894773002/40001
5 years, 10 months ago (2015-02-03 21:04:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894773002/40001
5 years, 10 months ago (2015-02-03 21:24:30 UTC) #22
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 21:24:41 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/65fd599e43247e139bc3e7afaff9392073fec1bc

Powered by Google App Engine
This is Rietveld 408576698