Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 894753006: Calls to the CallIC miss handler looked up the receiver incorrectly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 2771 matching lines...) Expand 10 before | Expand all | Expand 10 after
2782 __ JumpIfSmi(r1, &non_function); 2782 __ JumpIfSmi(r1, &non_function);
2783 2783
2784 // Goto slow case if we do not have a function. 2784 // Goto slow case if we do not have a function.
2785 __ CompareObjectType(r1, r4, r4, JS_FUNCTION_TYPE); 2785 __ CompareObjectType(r1, r4, r4, JS_FUNCTION_TYPE);
2786 __ b(ne, &slow); 2786 __ b(ne, &slow);
2787 __ jmp(&have_js_function); 2787 __ jmp(&have_js_function);
2788 } 2788 }
2789 2789
2790 2790
2791 void CallICStub::GenerateMiss(MacroAssembler* masm) { 2791 void CallICStub::GenerateMiss(MacroAssembler* masm) {
2792 // Get the receiver of the function from the stack; 1 ~ return address. 2792 // Get the receiver of the function from the stack.
2793 __ ldr(r4, MemOperand(sp, (arg_count() + 1) * kPointerSize)); 2793 __ ldr(r4, MemOperand(sp, arg_count() * kPointerSize));
2794 2794
2795 { 2795 {
2796 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL); 2796 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
2797 2797
2798 // Push the receiver and the function and feedback info. 2798 // Push the receiver and the function and feedback info.
2799 __ Push(r4, r1, r2, r3); 2799 __ Push(r4, r1, r2, r3);
2800 2800
2801 // Call the entry. 2801 // Call the entry.
2802 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss 2802 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
2803 : IC::kCallIC_Customization_Miss; 2803 : IC::kCallIC_Customization_Miss;
(...skipping 2165 matching lines...) Expand 10 before | Expand all | Expand 10 after
4969 kStackUnwindSpace, NULL, 4969 kStackUnwindSpace, NULL,
4970 MemOperand(fp, 6 * kPointerSize), NULL); 4970 MemOperand(fp, 6 * kPointerSize), NULL);
4971 } 4971 }
4972 4972
4973 4973
4974 #undef __ 4974 #undef __
4975 4975
4976 } } // namespace v8::internal 4976 } } // namespace v8::internal
4977 4977
4978 #endif // V8_TARGET_ARCH_ARM 4978 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698