Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 894723003: [Metro] Focus the user manager's web contents after the widget is shown (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Metro] Focus the user manager's web contents after the widget is shown Otherwise, on Ash, it seems to steal the initial focus away from the widget. BUG=453284 TEST=Start Chrome with --enable-new-avatar menu, and in Metro mode. Choose "Switch Person" from the avatar menu. In the user manager, start tabbing (without clicking on the user manager). This should work, and tabbing should change the selected user pod. Committed: https://crrev.com/a6afbb6a2348be8e59395c9e6f1ac543fd44f79c Cr-Commit-Position: refs/heads/master@{#314248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
noms (inactive)
I think this focus order makes more sense. Please take a look. Thanks!
5 years, 10 months ago (2015-02-02 23:21:33 UTC) #2
noms (inactive)
I think this focus order makes more sense. Please take a look. Thanks!
5 years, 10 months ago (2015-02-02 23:21:34 UTC) #3
sky
LGTM
5 years, 10 months ago (2015-02-03 00:42:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894723003/1
5 years, 10 months ago (2015-02-03 02:15:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 02:20:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 02:21:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6afbb6a2348be8e59395c9e6f1ac543fd44f79c
Cr-Commit-Position: refs/heads/master@{#314248}

Powered by Google App Engine
This is Rietveld 408576698