crypto/nss_util.cc - Issue 8947021: Destroy all Singletons and LazyInstances between each test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/nss_util.cc

Issue 8947021: Destroy all Singletons and LazyInstances between each test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: NSS Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/nss_util.cc

diff --git a/crypto/nss_util.cc b/crypto/nss_util.cc

index 9cd0cd1aa34be54f903d70df2445e2d4bf66e92e..b3fe4a21e6474d6d39aff5589f90e62d063ad4b8 100644

--- a/crypto/nss_util.cc

+++ b/crypto/nss_util.cc

@@ -746,9 +746,8 @@ ScopedTestNSSDB::ScopedTestNSSDB()

}

ScopedTestNSSDB::~ScopedTestNSSDB() {

- // TODO(mattm): Close the dababase once NSS 3.14 is required,

- // which fixes https://bugzilla.mozilla.org/show_bug.cgi?id=588269

- // Resource leaks are suppressed. http://crbug.com/156433 .

+ if (NSS_VersionCheck("3.14"))

+ g_nss_singleton.Get().CloseTestNSSDB();

}

base::Lock* GetNSSWriteLock() {