Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2185)

Unified Diff: base/test/test_suite.cc

Issue 8947021: Destroy all Singletons and LazyInstances between each test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ready for realz Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/test_suite.cc
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc
index 07b9964578a4a860712524443bf977505ef7119c..3def73a18c5fff08104a142e4d8eddcf185d2e25 100644
--- a/base/test/test_suite.cc
+++ b/base/test/test_suite.cc
@@ -76,6 +76,29 @@ class TestClientInitializer : public testing::EmptyTestEventListener {
DISALLOW_COPY_AND_ASSIGN(TestClientInitializer);
};
+// This class forces the destruction of all Singletons and LazyInstances
+// between tests.
+class SingletonDestructor : public testing::EmptyTestEventListener {
+ public:
+ SingletonDestructor() {}
+ virtual ~SingletonDestructor() {}
+
+ // testing::EmptyTestEventListener:
+ virtual void OnTestStart(
+ const testing::TestInfo& test_info) OVERRIDE {
+ at_exit_manager_.reset(new base::ShadowingAtExitManager);
+ }
+
+ virtual void OnTestEnd(const testing::TestInfo& test_info) OVERRIDE {
+ at_exit_manager_.reset();
+ }
+
+ private:
+ scoped_ptr<base::ShadowingAtExitManager> at_exit_manager_;
+
+ DISALLOW_COPY_AND_ASSIGN(SingletonDestructor);
+};
+
} // namespace
TestSuite::TestSuite(int argc, char** argv) : initialized_command_line_(false) {
@@ -252,8 +275,16 @@ void TestSuite::Initialize() {
CatchMaybeTests();
ResetCommandLine();
+ EnableSingletonTestIsolation();
+
TestTimeouts::Initialize();
}
void TestSuite::Shutdown() {
}
+
+void TestSuite::EnableSingletonTestIsolation() {
+ testing::TestEventListeners& listeners =
+ testing::UnitTest::GetInstance()->listeners();
+ listeners.Append(new SingletonDestructor);
+}

Powered by Google App Engine
This is Rietveld 408576698