Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 894693005: IDL: Auto-declare implied methods only if not otherwise declared (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Auto-declare implied methods only if not otherwise declared An interface with an iterable<>, maplike<> or setlike<> declaration should according to WebIDL have a number of additional methods, some of which we already auto-declare. Adjust this auto-declaration so that it's disabled if the interface has an explicitly declared method with the same name already. This allows an interface to override some or all of the implied methods, and for instance declare them with different extended attributes. BUG=432683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189805

Patch Set 1 #

Patch Set 2 : fix spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M Source/bindings/scripts/v8_interface.py View 2 chunks +12 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterface3.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Jens Widell
PTAL
5 years, 10 months ago (2015-02-09 11:02:59 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-09 11:31:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894693005/20001
5 years, 10 months ago (2015-02-09 11:34:05 UTC) #5
Yuki
lgtm
5 years, 10 months ago (2015-02-09 12:44:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/121197) Timed out jobs are ...
5 years, 10 months ago (2015-02-09 13:49:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894693005/20001
5 years, 10 months ago (2015-02-09 13:55:07 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 14:28:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189805

Powered by Google App Engine
This is Rietveld 408576698