Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 894693003: Add refcnting to SkClipStack on SkCanvas (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more cleanup #

Total comments: 3

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M include/core/SkCanvas.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkClipStack.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrClipData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 12 chunks +14 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ClipCacheTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
joshualitt
5 years, 10 months ago (2015-02-04 19:42:36 UTC) #3
mtklein
https://codereview.chromium.org/894693003/diff/20001/include/core/SkClipStack.h File include/core/SkClipStack.h (right): https://codereview.chromium.org/894693003/diff/20001/include/core/SkClipStack.h#newcode27 include/core/SkClipStack.h:27: class SK_API SkClipStack : public SkRefCnt { If this ...
5 years, 10 months ago (2015-02-04 19:47:49 UTC) #5
bsalomon
lgtm https://codereview.chromium.org/894693003/diff/20001/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/894693003/diff/20001/include/core/SkCanvas.h#newcode1084 include/core/SkCanvas.h:1084: return fClipStack.get(); Doesn't SkAutoTUnref implicitly cast to T*? ...
5 years, 10 months ago (2015-02-05 15:51:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894693003/40001
5 years, 10 months ago (2015-02-05 16:13:32 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 16:19:42 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/de358a9946fb6cffa905c7aa0e5f29cf6960b927

Powered by Google App Engine
This is Rietveld 408576698