test/unittests/compiler/js-typed-lowering-unittest.cc - Issue 894683003: Introduce LanguageMode, drop StrictMode.

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 894683003: Introduce LanguageMode, drop StrictMode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: . Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/unittests/compiler/js-typed-lowering-unittest.cc

diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc

index 5d1c8c698c30405e661e0196dc41975cd88e10ae..d260ff61debea04df04f657c1ce35b88a62ff778 100644

--- a/test/unittests/compiler/js-typed-lowering-unittest.cc

+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc

@@ -62,7 +62,7 @@ Type* const kJSTypes[] = {Type::Undefined(), Type::Null(), Type::Boolean(),

Type::Number(), Type::String(), Type::Object()};

-const StrictMode kStrictModes[] = {SLOPPY, STRICT};

+const LanguageMode kLanguageModes[] = {SLOPPY, STRICT};

rossberg 2015/02/03 12:26:20 Maybe add a static assert here as well, so that we

marja 2015/02/03 14:45:02 Done.

} // namespace

@@ -665,7 +665,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {

Handle<JSArrayBuffer> buffer =

NewArrayBuffer(backing_store, sizeof(backing_store));

TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {

- TRACED_FOREACH(StrictMode, strict_mode, kStrictModes) {

+ TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {

Handle<JSTypedArray> array =

factory()->NewJSTypedArray(type, buffer, 0, kLength);

int const element_size = static_cast<int>(array->element_size());

@@ -678,7 +678,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

- Node* node = graph()->NewNode(javascript()->StoreProperty(strict_mode),

+ Node* node = graph()->NewNode(javascript()->StoreProperty(language_mode),

base, key, value, context);

if (FLAG_turbo_deoptimization) {

node->AppendInput(zone(), UndefinedConstant());

@@ -711,7 +711,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {

Handle<JSArrayBuffer> buffer =

NewArrayBuffer(backing_store, sizeof(backing_store));

TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {

- TRACED_FOREACH(StrictMode, strict_mode, kStrictModes) {

+ TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {

Handle<JSTypedArray> array =

factory()->NewJSTypedArray(type, buffer, 0, kLength);

int const element_size = static_cast<int>(array->element_size());

@@ -723,7 +723,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

- Node* node = graph()->NewNode(javascript()->StoreProperty(strict_mode),

+ Node* node = graph()->NewNode(javascript()->StoreProperty(language_mode),

base, key, value, context);

if (FLAG_turbo_deoptimization) {

node->AppendInput(zone(), UndefinedConstant());

@@ -767,7 +767,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {

Handle<JSArrayBuffer> buffer =

NewArrayBuffer(backing_store, sizeof(backing_store));

TRACED_FOREACH(ExternalArrayType, type, kExternalArrayTypes) {

- TRACED_FOREACH(StrictMode, strict_mode, kStrictModes) {

+ TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {

Handle<JSTypedArray> array =

factory()->NewJSTypedArray(type, buffer, 0, kLength);

ElementAccess access = AccessBuilder::ForTypedArrayElement(type, true);

@@ -781,7 +781,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

- Node* node = graph()->NewNode(javascript()->StoreProperty(strict_mode),

+ Node* node = graph()->NewNode(javascript()->StoreProperty(language_mode),

base, key, value, context);

if (FLAG_turbo_deoptimization) {

node->AppendInput(zone(), UndefinedConstant());

« src/runtime/runtime-utils.h ('K') | « test/unittests/compiler/js-operator-unittest.cc ('k') | no next file » | no next file with comments »