Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: src/parser.h

Issue 894683003: Introduce LanguageMode, drop StrictMode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index 23b12e1c8d2260537b8c3b1c32ec27752da87380..a1804effc24ab80a64209a66fd2db140bc7c9bd8 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -31,7 +31,7 @@ class FunctionEntry BASE_EMBEDDED {
kEndPositionIndex,
kLiteralCountIndex,
kPropertyCountIndex,
- kStrictModeIndex,
+ kLanguageModeIndex,
kSize
};
@@ -44,10 +44,11 @@ class FunctionEntry BASE_EMBEDDED {
int end_pos() { return backing_[kEndPositionIndex]; }
int literal_count() { return backing_[kLiteralCountIndex]; }
int property_count() { return backing_[kPropertyCountIndex]; }
- StrictMode strict_mode() {
- DCHECK(backing_[kStrictModeIndex] == SLOPPY ||
- backing_[kStrictModeIndex] == STRICT);
- return static_cast<StrictMode>(backing_[kStrictModeIndex]);
+ LanguageMode language_mode() {
+ STATIC_ASSERT(LANGUAGE_END == 2);
+ DCHECK(backing_[kLanguageModeIndex] == SLOPPY ||
rossberg 2015/02/03 12:26:20 Same here, could use is_valid_l_m
marja 2015/02/03 14:45:02 Done.
+ backing_[kLanguageModeIndex] == STRICT);
+ return static_cast<LanguageMode>(backing_[kLanguageModeIndex]);
}
bool is_valid() { return !backing_.is_empty(); }
@@ -670,7 +671,7 @@ class Parser : public ParserBase<ParserTraits> {
Parser parser(info, &parse_info);
parser.set_allow_lazy(allow_lazy);
if (parser.Parse()) {
- info->SetStrictMode(info->function()->strict_mode());
+ info->SetLanguageMode(info->function()->language_mode());
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698