Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 894683002: Mechanical change for updating the paths to Push-related Blink API files. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mechanical change for updating the paths to Push-related Blink API files. Update the Chromium uses of the Blink Push API-related headers to match the new locations of these file. This is part of a three-sided patch: [1] https://codereview.chromium.org/888513003/ [2] This patch. [3] https://codereview.chromium.org/871643005/ BUG=453032 Committed: https://crrev.com/bffa93bac40ff98969e06b860485da53ecd675e4 Cr-Commit-Position: refs/heads/master@{#315012}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/push_messaging/push_provider.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/push_messaging/push_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/push_messaging_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/push_messaging_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
Peter Beverloo
+mvanouwerkerk for Push API. +jochen for the public/ module changes for Push API (mechanical Chromium-side ...
5 years, 10 months ago (2015-02-02 12:50:56 UTC) #2
Mike West
IPC (and content/shell) LGTM.
5 years, 10 months ago (2015-02-02 12:53:08 UTC) #3
Michael van Ouwerkerk
lgtm
5 years, 10 months ago (2015-02-02 13:59:08 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 12:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894683002/1
5 years, 10 months ago (2015-02-05 17:36:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/55840) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/7781) mac_chromium_compile_dbg_ng ...
5 years, 10 months ago (2015-02-05 17:39:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894683002/20001
5 years, 10 months ago (2015-02-05 18:08:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/52526)
5 years, 10 months ago (2015-02-05 19:06:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894683002/20001
5 years, 10 months ago (2015-02-06 10:55:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/52891)
5 years, 10 months ago (2015-02-06 11:03:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894683002/40001
5 years, 10 months ago (2015-02-06 11:37:20 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-06 12:26:29 UTC) #21
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 12:27:39 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bffa93bac40ff98969e06b860485da53ecd675e4
Cr-Commit-Position: refs/heads/master@{#315012}

Powered by Google App Engine
This is Rietveld 408576698