Files.app: Add Model class that is the set of MetadataCacheItem.

Files.app: Add Model class that is the set of MetadataCacheItem.

The CL adds MetadataCacheSet class that is the set of MetadataCacheItem.  The
class wraps MetadataCacheSetStorage interface (raw set of MetadataCacheItem),
and prvoides operations to the set of MetadataCacheItem.

BUG=410766
TEST=FileManagerJsTest.MetadataCacheSetTest

Committed: https://crrev.com/c209aa531a5858b123692f3084c3d8d44e5eade6
Cr-Commit-Position: refs/heads/master@{#314125}

[hirono, 2015-02-02 05:14:09]

Patchset #1 (id:1) has been deleted

[hirono, 2015-02-02 05:14:20]

Patchset #1 (id:1) has been deleted

[hirono, 2015-02-02 05:25:54]

Patchset #1 (id:20001) has been deleted

[hirono, 2015-02-02 07:46:24]

Patchset #1 (id:40001) has been deleted

[hirono, 2015-02-02 07:46:30]

Patchset #1 (id:60001) has been deleted

[hirono, 2015-02-02 07:46:35]

Patchset #1 (id:80001) has been deleted

[hirono, 2015-02-02 07:52:04]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-02-02 07:52:05]

PTAL? The tests are failed because the previous patch has not been submitted
yet. Thanks!

[yawano, 2015-02-02 08:35:36]

lgtm with nits. Thanks!

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js
(right):

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js:81: *
@param {number} requestId
nit: Please add comments for the parameters.

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
(right):

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js:42:
assertEquals(null, results[1].property);
nit: null -> undefined?

[hirono, 2015-02-02 09:02:38]

Patchset #2 (id:120001) has been deleted

[hirono, 2015-02-02 09:02:49]

Thanks!

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js
(right):

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js:81: *
@param {number} requestId
On 2015/02/02 08:35:36, yawano wrote:
> nit: Please add comments for the parameters.

Done.

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
(right):

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js:42:
assertEquals(null, results[1].property);
On 2015/02/02 08:35:36, yawano wrote:
> nit: null -> undefined?

This should be null because set.startRequests generates (empty) cache for
corresponding entries and properties.

Actually assertEquals fails if we passes undefined (I also specified undefined
while I was creating the test)

[hirono, 2015-02-02 09:09:37]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-02 09:10:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894633002/140001

[yawano, 2015-02-02 09:12:04]

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
(right):

https://codereview.chromium.org/894633002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js:42:
assertEquals(null, results[1].property);
On 2015/02/02 09:02:49, hirono wrote:
> On 2015/02/02 08:35:36, yawano wrote:
> > nit: null -> undefined?
> 
> This should be null because set.startRequests generates (empty) cache for
> corresponding entries and properties.
> 
> Actually assertEquals fails if we passes undefined (I also specified undefined
> while I was creating the test)
> 

Sorry, I missed it. Acknowledged. Thank you!

[commit-bot: I haz the power, 2015-02-02 10:22:44]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2015-02-02 10:23:44]

Patchset 2 (id:??) landed as
https://crrev.com/c209aa531a5858b123692f3084c3d8d44e5eade6
Cr-Commit-Position: refs/heads/master@{#314125}