Dart: 2++ = 3

Dart: 2++ = 3
BUG=

Committed: https://chromium.googlesource.com/external/mojo/+/0fc92de0468213f621cba0fbdfd96c1625052ba7

[rafaelw, 2015-02-02 04:23:18]

rafaelw@chromium.org changed reviewers:
+ eseidel@chromium.org, rmacnak@google.com

[rafaelw, 2015-02-02 04:32:07]

Committed patchset #3 (id:40001) manually as
0fc92de0468213f621cba0fbdfd96c1625052ba7.

[ojan, 2015-02-02 04:38:55]

ojan@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2015-02-02 04:38:56]

Can you please give better change descriptions in the future? This doesn't mean
anything to those of us not immersed in what changes are being made.

[eseidel, 2015-02-02 05:30:54]

This is a great start, thanks!

https://codereview.chromium.org/894613002/diff/40001/sky/engine/bindings-dart...
File sky/engine/bindings-dart/BUILD.gn (right):

https://codereview.chromium.org/894613002/diff/40001/sky/engine/bindings-dart...
sky/engine/bindings-dart/BUILD.gn:6: "dart_master.cpp"
Chromium is techincally .cc :p

[rafaelw, 2015-02-02 16:57:23]

https://codereview.chromium.org/894613002/diff/40001/sky/engine/bindings-dart...
File sky/engine/bindings-dart/BUILD.gn (right):

https://codereview.chromium.org/894613002/diff/40001/sky/engine/bindings-dart...
sky/engine/bindings-dart/BUILD.gn:6: "dart_master.cpp"
On 2015/02/02 05:30:54, eseidel wrote:
> Chromium is techincally .cc :p

Fixed in follow-on patch.

[jamesr, 2015-02-02 19:21:56]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-02-02 19:21:57]

If you didn't see this broke the android and asan builders:

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings
-m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -pthread
-B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=safe
-Wl,-O1 -Wl,--gc-sections -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link=
-Wl,--disable-new-dtags -o ./libdart_dependency_helper -Wl,--start-group
@./libdart_dependency_helper.rsp  -Wl,--end-group  -ldl -lpthread -lrt 
obj/dart/runtime/vm/libdart_dependency_helper.libdart_dependency_helper.o:../../dart/runtime/vm/libdart_dependency_helper.cc:function
asan.module_ctor: error: undefined reference to '__asan_init_v4'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

and

FAILED: /b/build/goma/gomacc
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/sky/engine/bindings2/bindings2.dart_master.o.d -DCHROMIUM_BUILD
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS
-DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL
-DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1
-DENABLE_AUTOFILL_DIALOG=1 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DUSE_STLPORT=1
-D_STLP_USE_PTR_SPECIALIZATIONS=1 -D__GNU_SOURCE=1 -DNDEBUG -I../.. -Igen
-fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a
-mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC
-pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64
-mfpu=vfpv3-d16 -Wall -Wsign-compare -Wendif-labels -Werror
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra
-Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport
-fvisibility=hidden
--sysroot=/b/build/slave/mojo/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm
-fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -Os -g2
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing
-Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor
-Wno-sign-promo -fno-rtti -fno-exceptions -c
../../sky/engine/bindings2/dart_master.cc -o
obj/sky/engine/bindings2/bindings2.dart_master.o
../../sky/engine/bindings2/dart_master.cc: In static member function 'static
void blink::DartMaster::InitVM()':
../../sky/engine/bindings2/dart_master.cc:43:8: error: variable 'result' set but
not used [-Werror=unused-but-set-variable]
   bool result = Dart_SetVMFlags(0, NULL);
        ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

please use the trybots - they are super fast!

[abarth-chromium, 2015-02-02 20:27:06]

On 2015/02/02 at 19:21:57, jamesr wrote:
> please use the trybots - they are super fast!

Sorry, that was my mistake.  I pushed to the wrong repo.  Reverted the mistaken
push in https://codereview.chromium.org/860273005/