Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Mac Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc
index b3571d6b3384b2b690b2987418427bb155dae96d..6be027c9c10c292ae6c2d11dd2b9f1153a7d91b3 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc
@@ -142,7 +142,7 @@ scoped_ptr<PasswordForm> FormFromAttributes(GnomeKeyringAttributeList* attrs) {
form->display_name = UTF8ToUTF16(string_attr_map["display_name"]);
form->avatar_url = GURL(string_attr_map["avatar_url"]);
form->federation_url = GURL(string_attr_map["federation_url"]);
- form->is_zero_click = uint_attr_map["is_zero_click"];
+ form->skip_next_zero_click = uint_attr_map["skip_next_zero_click"];
return form.Pass();
}
@@ -230,7 +230,7 @@ const GnomeKeyringPasswordSchema kGnomeSchema = {
{ "display_name", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ "avatar_url", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ "federation_url", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
- { "is_zero_click", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
+ { "skip_next_zero_click", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
Mike West 2015/02/03 14:15:40 Is there no bool type?
vasilii 2015/02/03 19:49:17 There are just a string and a number :-D https://d
// This field is always "chrome" so that we can search for it.
{ "application", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ NULL }
@@ -349,7 +349,7 @@ void GKRMethod::AddLogin(const PasswordForm& form, const char* app_string) {
"display_name", UTF16ToUTF8(form.display_name).c_str(),
"avatar_url", form.avatar_url.spec().c_str(),
"federation_url", form.federation_url.spec().c_str(),
- "is_zero_click", form.is_zero_click,
+ "skip_next_zero_click", form.skip_next_zero_click,
"application", app_string,
NULL);
}

Powered by Google App Engine
This is Rietveld 408576698