Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/browser/password_manager/password_store_mac_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix linux Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_mac.h" 5 #include "chrome/browser/password_manager/password_store_mac.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/scoped_observer.h" 9 #include "base/scoped_observer.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 form->action = GURL(form_data.action); 248 form->action = GURL(form_data.action);
249 if (form_data.submit_element) 249 if (form_data.submit_element)
250 form->submit_element = WideToUTF16(form_data.submit_element); 250 form->submit_element = WideToUTF16(form_data.submit_element);
251 if (form_data.username_element) 251 if (form_data.username_element)
252 form->username_element = WideToUTF16(form_data.username_element); 252 form->username_element = WideToUTF16(form_data.username_element);
253 if (form_data.password_element) 253 if (form_data.password_element)
254 form->password_element = WideToUTF16(form_data.password_element); 254 form->password_element = WideToUTF16(form_data.password_element);
255 if (form_data.username_value) { 255 if (form_data.username_value) {
256 form->username_value = WideToUTF16(form_data.username_value); 256 form->username_value = WideToUTF16(form_data.username_value);
257 form->display_name = form->username_value; 257 form->display_name = form->username_value;
258 form->is_zero_click = true; 258 form->skip_zero_click = true;
259 if (form_data.password_value) 259 if (form_data.password_value)
260 form->password_value = WideToUTF16(form_data.password_value); 260 form->password_value = WideToUTF16(form_data.password_value);
261 } else { 261 } else {
262 form->blacklisted_by_user = true; 262 form->blacklisted_by_user = true;
263 } 263 }
264 form->avatar_url = GURL("https://accounts.google.com/Avatar"); 264 form->avatar_url = GURL("https://accounts.google.com/Avatar");
265 form->federation_url = GURL("https://accounts.google.com/login"); 265 form->federation_url = GURL("https://accounts.google.com/login");
266 return form; 266 return form;
267 } 267 }
268 268
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 << test_label; 300 << test_label;
301 EXPECT_EQ(WideToUTF16(expectation->username_element), 301 EXPECT_EQ(WideToUTF16(expectation->username_element),
302 form->username_element) << test_label; 302 form->username_element) << test_label;
303 EXPECT_EQ(WideToUTF16(expectation->password_element), 303 EXPECT_EQ(WideToUTF16(expectation->password_element),
304 form->password_element) << test_label; 304 form->password_element) << test_label;
305 if (expectation->username_value) { 305 if (expectation->username_value) {
306 EXPECT_EQ(WideToUTF16(expectation->username_value), 306 EXPECT_EQ(WideToUTF16(expectation->username_value),
307 form->username_value) << test_label; 307 form->username_value) << test_label;
308 EXPECT_EQ(WideToUTF16(expectation->username_value), 308 EXPECT_EQ(WideToUTF16(expectation->username_value),
309 form->display_name) << test_label; 309 form->display_name) << test_label;
310 EXPECT_TRUE(form->is_zero_click) << test_label; 310 EXPECT_TRUE(form->skip_zero_click) << test_label;
311 EXPECT_EQ(WideToUTF16(expectation->password_value), 311 EXPECT_EQ(WideToUTF16(expectation->password_value),
312 form->password_value) << test_label; 312 form->password_value) << test_label;
313 } else { 313 } else {
314 EXPECT_TRUE(form->blacklisted_by_user) << test_label; 314 EXPECT_TRUE(form->blacklisted_by_user) << test_label;
315 } 315 }
316 EXPECT_EQ(expectation->preferred, form->preferred) << test_label; 316 EXPECT_EQ(expectation->preferred, form->preferred) << test_label;
317 EXPECT_EQ(expectation->ssl_valid, form->ssl_valid) << test_label; 317 EXPECT_EQ(expectation->ssl_valid, form->ssl_valid) << test_label;
318 EXPECT_DOUBLE_EQ(expectation->creation_time, 318 EXPECT_DOUBLE_EQ(expectation->creation_time,
319 form->date_created.ToDoubleT()) << test_label; 319 form->date_created.ToDoubleT()) << test_label;
320 base::Time created = base::Time::FromDoubleT(expectation->creation_time); 320 base::Time created = base::Time::FromDoubleT(expectation->creation_time);
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1571 1571
1572 // Delete one login; a range of logins. 1572 // Delete one login; a range of logins.
1573 store()->RemoveLogin(*form); 1573 store()->RemoveLogin(*form);
1574 store()->RemoveLoginsCreatedBetween(base::Time(), base::Time::Max()); 1574 store()->RemoveLoginsCreatedBetween(base::Time(), base::Time::Max());
1575 store()->RemoveLoginsSyncedBetween(base::Time(), base::Time::Max()); 1575 store()->RemoveLoginsSyncedBetween(base::Time(), base::Time::Max());
1576 FinishAsyncProcessing(); 1576 FinishAsyncProcessing();
1577 1577
1578 // Verify no notifications are fired during shutdown either. 1578 // Verify no notifications are fired during shutdown either.
1579 ClosePasswordStore(); 1579 ClosePasswordStore();
1580 } 1580 }
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret_unittest.cc ('k') | components/autofill/core/common/password_form.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698