Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix linux Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdarg.h> 5 #include <stdarg.h>
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 // We don't check the date created. It varies due to bug in the 239 // We don't check the date created. It varies due to bug in the
240 // serialization. Integer seconds are saved instead of microseconds. 240 // serialization. Integer seconds are saved instead of microseconds.
241 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 241 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
242 EXPECT_EQ(expected.type, actual.type); 242 EXPECT_EQ(expected.type, actual.type);
243 EXPECT_EQ(expected.times_used, actual.times_used); 243 EXPECT_EQ(expected.times_used, actual.times_used);
244 EXPECT_EQ(expected.scheme, actual.scheme); 244 EXPECT_EQ(expected.scheme, actual.scheme);
245 EXPECT_EQ(expected.date_synced, actual.date_synced); 245 EXPECT_EQ(expected.date_synced, actual.date_synced);
246 EXPECT_EQ(expected.display_name, actual.display_name); 246 EXPECT_EQ(expected.display_name, actual.display_name);
247 EXPECT_EQ(expected.avatar_url, actual.avatar_url); 247 EXPECT_EQ(expected.avatar_url, actual.avatar_url);
248 EXPECT_EQ(expected.federation_url, actual.federation_url); 248 EXPECT_EQ(expected.federation_url, actual.federation_url);
249 EXPECT_EQ(expected.is_zero_click, actual.is_zero_click); 249 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
250 } 250 }
251 } 251 }
252 252
253 void CheckPasswordChangesWithResult(const PasswordStoreChangeList* expected, 253 void CheckPasswordChangesWithResult(const PasswordStoreChangeList* expected,
254 const PasswordStoreChangeList* actual, 254 const PasswordStoreChangeList* actual,
255 bool result) { 255 bool result) {
256 EXPECT_TRUE(result); 256 EXPECT_TRUE(result);
257 CheckPasswordChanges(*expected, *actual); 257 CheckPasswordChanges(*expected, *actual);
258 } 258 }
259 259
(...skipping 22 matching lines...) Expand all
282 form_google_.password_element = UTF8ToUTF16("pass"); 282 form_google_.password_element = UTF8ToUTF16("pass");
283 form_google_.password_value = UTF8ToUTF16("seekrit"); 283 form_google_.password_value = UTF8ToUTF16("seekrit");
284 form_google_.submit_element = UTF8ToUTF16("submit"); 284 form_google_.submit_element = UTF8ToUTF16("submit");
285 form_google_.signon_realm = "http://www.google.com/"; 285 form_google_.signon_realm = "http://www.google.com/";
286 form_google_.type = PasswordForm::TYPE_GENERATED; 286 form_google_.type = PasswordForm::TYPE_GENERATED;
287 form_google_.date_created = base::Time::Now(); 287 form_google_.date_created = base::Time::Now();
288 form_google_.date_synced = base::Time::Now(); 288 form_google_.date_synced = base::Time::Now();
289 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 289 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
290 form_google_.avatar_url = GURL("http://www.google.com/avatar"); 290 form_google_.avatar_url = GURL("http://www.google.com/avatar");
291 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 291 form_google_.federation_url = GURL("http://www.google.com/federation_url");
292 form_google_.is_zero_click = true; 292 form_google_.skip_zero_click = true;
293 293
294 form_facebook_.origin = GURL("http://www.facebook.com/"); 294 form_facebook_.origin = GURL("http://www.facebook.com/");
295 form_facebook_.action = GURL("http://www.facebook.com/login"); 295 form_facebook_.action = GURL("http://www.facebook.com/login");
296 form_facebook_.username_element = UTF8ToUTF16("user"); 296 form_facebook_.username_element = UTF8ToUTF16("user");
297 form_facebook_.username_value = UTF8ToUTF16("a"); 297 form_facebook_.username_value = UTF8ToUTF16("a");
298 form_facebook_.password_element = UTF8ToUTF16("password"); 298 form_facebook_.password_element = UTF8ToUTF16("password");
299 form_facebook_.password_value = UTF8ToUTF16("b"); 299 form_facebook_.password_value = UTF8ToUTF16("b");
300 form_facebook_.submit_element = UTF8ToUTF16("submit"); 300 form_facebook_.submit_element = UTF8ToUTF16("submit");
301 form_facebook_.signon_realm = "http://www.facebook.com/"; 301 form_facebook_.signon_realm = "http://www.facebook.com/";
302 form_facebook_.date_created = base::Time::Now(); 302 form_facebook_.date_created = base::Time::Now();
303 form_facebook_.date_synced = base::Time::Now(); 303 form_facebook_.date_synced = base::Time::Now();
304 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe"); 304 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");
305 form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar"); 305 form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar");
306 form_facebook_.federation_url = GURL("http://www.facebook.com/federation"); 306 form_facebook_.federation_url = GURL("http://www.facebook.com/federation");
307 form_facebook_.is_zero_click = true; 307 form_facebook_.skip_zero_click = true;
308 308
309 form_isc_.origin = GURL("http://www.isc.org/"); 309 form_isc_.origin = GURL("http://www.isc.org/");
310 form_isc_.action = GURL("http://www.isc.org/auth"); 310 form_isc_.action = GURL("http://www.isc.org/auth");
311 form_isc_.username_element = UTF8ToUTF16("id"); 311 form_isc_.username_element = UTF8ToUTF16("id");
312 form_isc_.username_value = UTF8ToUTF16("janedoe"); 312 form_isc_.username_value = UTF8ToUTF16("janedoe");
313 form_isc_.password_element = UTF8ToUTF16("passwd"); 313 form_isc_.password_element = UTF8ToUTF16("passwd");
314 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 314 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
315 form_isc_.submit_element = UTF8ToUTF16("login"); 315 form_isc_.submit_element = UTF8ToUTF16("login");
316 form_isc_.signon_realm = "http://www.isc.org/"; 316 form_isc_.signon_realm = "http://www.isc.org/";
317 form_isc_.date_created = base::Time::Now(); 317 form_isc_.date_created = base::Time::Now();
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user); 381 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user);
382 CheckUint32Attribute(item, "type", form.type); 382 CheckUint32Attribute(item, "type", form.type);
383 CheckUint32Attribute(item, "times_used", form.times_used); 383 CheckUint32Attribute(item, "times_used", form.times_used);
384 CheckUint32Attribute(item, "scheme", form.scheme); 384 CheckUint32Attribute(item, "scheme", form.scheme);
385 CheckStringAttribute( 385 CheckStringAttribute(
386 item, "date_synced", 386 item, "date_synced",
387 base::Int64ToString(form.date_synced.ToInternalValue())); 387 base::Int64ToString(form.date_synced.ToInternalValue()));
388 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name)); 388 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));
389 CheckStringAttribute(item, "avatar_url", form.avatar_url.spec()); 389 CheckStringAttribute(item, "avatar_url", form.avatar_url.spec());
390 CheckStringAttribute(item, "federation_url", form.federation_url.spec()); 390 CheckStringAttribute(item, "federation_url", form.federation_url.spec());
391 CheckUint32Attribute(item, "is_zero_click", form.is_zero_click); 391 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);
392 CheckStringAttribute(item, "application", app_string); 392 CheckStringAttribute(item, "application", app_string);
393 } 393 }
394 394
395 // Saves |credentials| and then gets logins matching |url| and |scheme|. 395 // Saves |credentials| and then gets logins matching |url| and |scheme|.
396 // Returns true when something is found, and in such case copies the result to 396 // Returns true when something is found, and in such case copies the result to
397 // |result| when |result| is not nullptr. (Note that there can be max. 1 397 // |result| when |result| is not nullptr. (Note that there can be max. 1
398 // result derived from |credentials|.) 398 // result derived from |credentials|.)
399 bool CheckCredentialAvailability(const PasswordForm& credentials, 399 bool CheckCredentialAvailability(const PasswordForm& credentials,
400 const GURL& url, 400 const GURL& url,
401 const PasswordForm::Scheme& scheme, 401 const PasswordForm::Scheme& scheme,
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
836 836
837 ScopedVector<autofill::PasswordForm> form_list; 837 ScopedVector<autofill::PasswordForm> form_list;
838 backend.GetAutofillableLogins(&form_list); 838 backend.GetAutofillableLogins(&form_list);
839 839
840 EXPECT_EQ(1u, form_list.size()); 840 EXPECT_EQ(1u, form_list.size());
841 EXPECT_EQ(GURL(""), form_list[0]->avatar_url); 841 EXPECT_EQ(GURL(""), form_list[0]->avatar_url);
842 EXPECT_FALSE(form_list[0]->ssl_valid); 842 EXPECT_FALSE(form_list[0]->ssl_valid);
843 } 843 }
844 844
845 // TODO(mdm): add more basic tests here at some point. 845 // TODO(mdm): add more basic tests here at some point.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698