Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 894583003: Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix linux Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <map> 6 #include <map>
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 160
161 form_google_ = old_form_google_; 161 form_google_ = old_form_google_;
162 form_google_.times_used = 3; 162 form_google_.times_used = 3;
163 form_google_.type = PasswordForm::TYPE_GENERATED; 163 form_google_.type = PasswordForm::TYPE_GENERATED;
164 form_google_.form_data.name = UTF8ToUTF16("form_name"); 164 form_google_.form_data.name = UTF8ToUTF16("form_name");
165 form_google_.form_data.user_submitted = true; 165 form_google_.form_data.user_submitted = true;
166 form_google_.date_synced = base::Time::Now(); 166 form_google_.date_synced = base::Time::Now();
167 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 167 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
168 form_google_.avatar_url = GURL("http://www.google.com/avatar"); 168 form_google_.avatar_url = GURL("http://www.google.com/avatar");
169 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 169 form_google_.federation_url = GURL("http://www.google.com/federation_url");
170 form_google_.is_zero_click = true; 170 form_google_.skip_zero_click = true;
171 171
172 form_isc_.origin = GURL("http://www.isc.org/"); 172 form_isc_.origin = GURL("http://www.isc.org/");
173 form_isc_.action = GURL("http://www.isc.org/auth"); 173 form_isc_.action = GURL("http://www.isc.org/auth");
174 form_isc_.username_element = UTF8ToUTF16("id"); 174 form_isc_.username_element = UTF8ToUTF16("id");
175 form_isc_.username_value = UTF8ToUTF16("janedoe"); 175 form_isc_.username_value = UTF8ToUTF16("janedoe");
176 form_isc_.password_element = UTF8ToUTF16("passwd"); 176 form_isc_.password_element = UTF8ToUTF16("passwd");
177 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 177 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
178 form_isc_.submit_element = UTF8ToUTF16("login"); 178 form_isc_.submit_element = UTF8ToUTF16("login");
179 form_isc_.signon_realm = "ISC"; 179 form_isc_.signon_realm = "ISC";
180 form_isc_.date_synced = base::Time::Now(); 180 form_isc_.date_synced = base::Time::Now();
(...skipping 28 matching lines...) Expand all
209 EXPECT_EQ(expected.preferred, actual.preferred); 209 EXPECT_EQ(expected.preferred, actual.preferred);
210 // We don't check the date created. It varies. 210 // We don't check the date created. It varies.
211 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 211 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
212 EXPECT_EQ(expected.type, actual.type); 212 EXPECT_EQ(expected.type, actual.type);
213 EXPECT_EQ(expected.times_used, actual.times_used); 213 EXPECT_EQ(expected.times_used, actual.times_used);
214 EXPECT_EQ(expected.scheme, actual.scheme); 214 EXPECT_EQ(expected.scheme, actual.scheme);
215 EXPECT_EQ(expected.date_synced, actual.date_synced); 215 EXPECT_EQ(expected.date_synced, actual.date_synced);
216 EXPECT_EQ(expected.display_name, actual.display_name); 216 EXPECT_EQ(expected.display_name, actual.display_name);
217 EXPECT_EQ(expected.avatar_url, actual.avatar_url); 217 EXPECT_EQ(expected.avatar_url, actual.avatar_url);
218 EXPECT_EQ(expected.federation_url, actual.federation_url); 218 EXPECT_EQ(expected.federation_url, actual.federation_url);
219 EXPECT_EQ(expected.is_zero_click, actual.is_zero_click); 219 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
220 } 220 }
221 221
222 // static 222 // static
223 void NativeBackendKWalletTestBase::CheckPasswordChanges( 223 void NativeBackendKWalletTestBase::CheckPasswordChanges(
224 const PasswordStoreChangeList& expected, 224 const PasswordStoreChangeList& expected,
225 const PasswordStoreChangeList& actual) { 225 const PasswordStoreChangeList& actual) {
226 ASSERT_EQ(expected.size(), actual.size()); 226 ASSERT_EQ(expected.size(), actual.size());
227 for (size_t i = 0; i < expected.size(); ++i) { 227 for (size_t i = 0; i < expected.size(); ++i) {
228 EXPECT_EQ(expected[i].type(), actual[i].type()); 228 EXPECT_EQ(expected[i].type(), actual[i].type());
229 CheckPasswordForm(expected[i].form(), actual[i].form()); 229 CheckPasswordForm(expected[i].form(), actual[i].form());
(...skipping 759 matching lines...) Expand 10 before | Expand all | Expand 10 after
989 pickle->WriteInt64(form.date_created.ToTimeT()); 989 pickle->WriteInt64(form.date_created.ToTimeT());
990 } 990 }
991 991
992 void NativeBackendKWalletPickleTest::CheckVersion3Pickle() { 992 void NativeBackendKWalletPickleTest::CheckVersion3Pickle() {
993 Pickle pickle; 993 Pickle pickle;
994 PasswordForm form = form_google_; 994 PasswordForm form = form_google_;
995 // Remove the fields which were not present in version #3. 995 // Remove the fields which were not present in version #3.
996 form.display_name.clear(); 996 form.display_name.clear();
997 form.avatar_url = GURL(); 997 form.avatar_url = GURL();
998 form.federation_url = GURL(); 998 form.federation_url = GURL();
999 form.is_zero_click = false; 999 form.skip_zero_click = false;
1000 CreateVersion3Pickle(form, &pickle); 1000 CreateVersion3Pickle(form, &pickle);
1001 1001
1002 ScopedVector<PasswordForm> form_list; 1002 ScopedVector<PasswordForm> form_list;
1003 NativeBackendKWalletStub::DeserializeValue(form.signon_realm, pickle, 1003 NativeBackendKWalletStub::DeserializeValue(form.signon_realm, pickle,
1004 &form_list); 1004 &form_list);
1005 1005
1006 EXPECT_EQ(1u, form_list.size()); 1006 EXPECT_EQ(1u, form_list.size());
1007 if (form_list.size() > 0) 1007 if (form_list.size() > 0)
1008 CheckPasswordForm(form, *form_list[0]); 1008 CheckPasswordForm(form, *form_list[0]);
1009 } 1009 }
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1106 CheckVersion1Pickle(); 1106 CheckVersion1Pickle();
1107 } 1107 }
1108 1108
1109 TEST_F(NativeBackendKWalletPickleTest, CheckVersion2Pickle) { 1109 TEST_F(NativeBackendKWalletPickleTest, CheckVersion2Pickle) {
1110 CheckVersion2Pickle(); 1110 CheckVersion2Pickle();
1111 } 1111 }
1112 1112
1113 TEST_F(NativeBackendKWalletPickleTest, CheckVersion3Pickle) { 1113 TEST_F(NativeBackendKWalletPickleTest, CheckVersion3Pickle) {
1114 CheckVersion3Pickle(); 1114 CheckVersion3Pickle();
1115 } 1115 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698