Rename PasswordForm::is_zero_click to PasswordForm::skip_next_zero_click.

components/test/data/password_manager/login_db_v10.sql

 PRAGMA foreign_keys=OFF;
 BEGIN TRANSACTION;
 CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR);
 INSERT INTO "meta" VALUES('last_compatible_version','1');
 INSERT INTO "meta" VALUES('version','9');
 CREATE TABLE logins (
 origin_url VARCHAR NOT NULL,
 action_url VARCHAR,
 username_element VARCHAR,
 username_value VARCHAR,
@@ skipping 37 matching lines @@
 0, /* date_synced */
 '', /* display_name */
 '', /* avatar_url */
 '', /* federation_url */
 0  /* is_zero_click */
 );
 INSERT INTO "logins" VALUES(
 'https://accounts.google.com/ServiceLogin', /* origin_url */
 'https://accounts.google.com/ServiceLoginAuth', /* action_url */
 'Email', /* username_element */
-'theerikchen2', /* username_value */
+'theerikchen', /* username_value */

[Mike West, 2015/02/03 14:15:41]

Why this change?

[vasilii, 2015/02/03 19:49:18]

I can leave it as it was before. But the test won't be strong enough. If you
look at the SQL query for migration, you'll see "INSERT OR REPLACE". It's very
important ("OR REPLACE") because previous versions may contain rows which will
violate the new 'UNIQUE' constraint. This test simulates the described
situation.

 'Passwd', /* password_element */
 X'', /* password_value */
-'', /* submit_element */
+'non-empty', /* submit_element */

[Mike West, 2015/02/03 14:15:41]

And this one?

[vasilii, 2015/02/03 19:49:17]

The 2 forms here have the same (origin_url, username_element, username_value,
password_element, signon_realm) but different "submit_element". submit_element
used to be a part of the UNIQUE column set.

 'https://accounts.google.com/', /* signon_realm */
 1, /* ssl_valid */
 1, /* preferred */
 13047423600000000, /* date_created */
 0, /* blacklisted_by_user */
 0, /* scheme */
 0, /* password_type */
 X'00000000', /* possible_usernames */
 1, /* times_used */
 X'18000000020000000000000000000000000000000000000000000000', /* form_data */
 0, /* date_synced */
 '', /* display_name */
 '', /* avatar_url */
 '', /* federation_url */
 0  /* is_zero_click */
 );
 CREATE INDEX logins_signon ON logins (signon_realm);
 COMMIT;