Add build targets for Opus tests.

Add build targets for Opus tests.

test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding
can be run directly, with no command-line options, and they print out
"OK" during the test and an overall status message such as
"All API tests passed." or "Tests completed successfully." at the end.

The celt component has several unit tests. I didn't add build targets
for them because some of them don't print any output, so you'd need a
test harness script to examine their exit status.

R=henrika@chromium.org,sergeyu@chromium.org
BUG=452984
Committed: https://crrev.com/8b76b75f78ffdb9760ee7eea4f149c5d2b64bc89
Cr-Commit-Position: refs/heads/master@{#314235}

[wtc, 2015-02-01 04:57:16]

wtc@chromium.org changed reviewers:
+ brettw@chromium.org

[wtc, 2015-02-02 18:56:59]

Please review this relanding CL.

Patch set 1 is the same as the original CL that you reviewed before at
https://codereview.chromium.org/890473002/

Patch set 2 fixes the compiler warnings in the test_opus_decode target when gcc
or clang is used. An example of the compilation error (because we use -Werror)
is at
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds...

The best fix would be to modify the test_opus_decode.c source code to turn off
-Wnonnull around the relevant code. But that requires patching the upstream
code. (I may pursue that if I have spare time.) So I am turning off -Wnonnull in
our GYP and GN build systems.

You just need to review the diffs between patch sets 1 and 2. Thanks.

[Sergey Ulanov, 2015-02-02 19:04:38]

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gy...
third_party/opus/opus.gyp:230: 'cflags': ['-Wno-nonnull'],
Does this work with both gcc and clang?

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gy...
third_party/opus/opus.gyp:234: 'WARNING_CFLAGS': ['-Wno-nonnull'],
Why do we need this in xcode_settings, but not in cflags on mac?

[wtc, 2015-02-02 21:45:47]

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gy...
third_party/opus/opus.gyp:230: 'cflags': ['-Wno-nonnull'],

On 2015/02/02 19:04:38, Sergey Ulanov wrote:
> Does this work with both gcc and clang?

Yes, -Wnonnull and -Wno-nonnull work with both gcc and clang.

-Wnonnull is documented in the GCC 4.0.4 manual (the oldest GCC 4.x version I
can find):
https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Warning-Options.html#Warning-Opt...

So this is a very old gcc feature. I verified this CL on Mac, which uses clang.

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gy...
third_party/opus/opus.gyp:234: 'WARNING_CFLAGS': ['-Wno-nonnull'],

On 2015/02/02 19:04:38, Sergey Ulanov wrote:
> Why do we need this in xcode_settings, but not in cflags on mac? 

This is a limitation of GYP. On Mac, xcode_settings is used instead of cflags,
even for Ninja builds. (It tooks me almost two hours last Friday to discover
this the hard way.)

[wtc, 2015-02-02 21:47:21]

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/894473002/diff/20001/third_party/opus/opus.gy...
third_party/opus/opus.gyp:234: 'WARNING_CFLAGS': ['-Wno-nonnull'],

I forgot to add that Mark Mentovai confirmed this is the case.

[brettw, 2015-02-02 21:57:57]

gn LGTM

[Sergey Ulanov, 2015-02-02 22:29:42]

lgtm

[wtc, 2015-02-03 01:00:34]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2015-02-03 01:02:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894473002/20001

[commit-bot: I haz the power, 2015-02-03 01:32:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-03 01:33:42]

Patchset 2 (id:??) landed as
https://crrev.com/8b76b75f78ffdb9760ee7eea4f149c5d2b64bc89
Cr-Commit-Position: refs/heads/master@{#314235}

[wtc, 2015-02-03 03:04:17]

On 2015/02/02 18:56:59, wtc wrote:
>
> The best fix would be to modify the test_opus_decode.c source code to turn off
> -Wnonnull around the relevant code. But that requires patching the upstream
> code. (I may pursue that if I have spare time.)

I just submitted a patch to the Opus codec project:
https://trac.xiph.org/ticket/2160

[henrika (OOO until Aug 14), 2015-02-03 09:34:07]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/884483005/ by henrika@chromium.org.

The reason for reverting is: This CL breaks WebRTC in Chrome and must be
reverted. Contact tlegrand@ for more details..