Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: build/common.gypi

Issue 894463003: Linux: Enable multi-threading with the gold linker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4381 matching lines...) Expand 10 before | Expand all | Expand 10 after
4392 'ldflags': [ '-fuse-ld=gold', ], 4392 'ldflags': [ '-fuse-ld=gold', ],
4393 4393
4394 'target_conditions': [ 4394 'target_conditions': [
4395 ['_toolset=="target"', { 4395 ['_toolset=="target"', {
4396 'ldflags': [ 4396 'ldflags': [
4397 # Experimentation found that using four linking threads 4397 # Experimentation found that using four linking threads
4398 # saved ~20% of link time. 4398 # saved ~20% of link time.
4399 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36 4399 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
4400 # Only apply this to the target linker, since the host 4400 # Only apply this to the target linker, since the host
4401 # linker might not be gold, but isn't used much anyway. 4401 # linker might not be gold, but isn't used much anyway.
4402 # TODO(raymes): Disable threading because gold is frequently 4402 '-Wl,--threads',
4403 # crashing on the bots: crbug.com/161942. 4403 '-Wl,--thread-count=4',
tzik 2015/02/05 07:15:22 Could you update corresponding part in build/confi
Lei Zhang 2015/02/05 23:27:31 Done.
4404 # '-Wl,--threads',
4405 # '-Wl,--thread-count=4',
4406 ], 4404 ],
4407 }], 4405 }],
4408 ], 4406 ],
4409 'conditions': [ 4407 'conditions': [
4410 ['release_valgrind_build==0 and order_profiling==0', { 4408 ['release_valgrind_build==0 and order_profiling==0', {
4411 'target_conditions': [ 4409 'target_conditions': [
4412 ['_toolset=="target"', { 4410 ['_toolset=="target"', {
4413 'ldflags': [ 4411 'ldflags': [
4414 '-Wl,--icf=safe', 4412 '-Wl,--icf=safe',
4415 ], 4413 ],
(...skipping 1469 matching lines...) Expand 10 before | Expand all | Expand 10 after
5885 # settings in target dicts. SYMROOT is a special case, because many other 5883 # settings in target dicts. SYMROOT is a special case, because many other
5886 # Xcode variables depend on it, including variables such as 5884 # Xcode variables depend on it, including variables such as
5887 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5885 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5888 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5886 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5889 # files to appear (when present) in the UI as actual files and not red 5887 # files to appear (when present) in the UI as actual files and not red
5890 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5888 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5891 # and therefore SYMROOT, needs to be set at the project level. 5889 # and therefore SYMROOT, needs to be set at the project level.
5892 'SYMROOT': '<(DEPTH)/xcodebuild', 5890 'SYMROOT': '<(DEPTH)/xcodebuild',
5893 }, 5891 },
5894 } 5892 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698