Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 894453004: Use TintedImageButton for accessibility tab switcher. (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TintedImageButton for accessibility tab switcher. Close icon switched approved in crbug.com/455002 BUG=455002 Committed: https://crrev.com/be606d08268052fd205d27c873a9baffe3b0d6d7 Cr-Commit-Position: refs/heads/master@{#314650}

Patch Set 1 #

Patch Set 2 : Switch to btn_close #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -63 lines) Patch
A chrome/android/java/res/drawable-hdpi/btn_incognito_tabs.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/btn_normal_tabs.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/tab_close_white.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/tab_close_white_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/tabstrip_incognito_switch_incognito.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/tabstrip_incognito_switch_incognito_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/tabstrip_incognito_switch_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/tabstrip_incognito_switch_normal_active.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/btn_incognito_tabs.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/btn_normal_tabs.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tab_close_white.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tab_close_white_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabstrip_incognito_switch_incognito.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabstrip_incognito_switch_incognito_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabstrip_incognito_switch_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabstrip_incognito_switch_normal_active.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/btn_incognito_tabs.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/btn_normal_tabs.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/tab_close_white.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/tab_close_white_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/tabstrip_incognito_switch_incognito.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/tabstrip_incognito_switch_incognito_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/tabstrip_incognito_switch_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/tabstrip_incognito_switch_normal_active.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/btn_incognito_tabs.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/btn_normal_tabs.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tab_close_white.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tab_close_white_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabstrip_incognito_switch_incognito.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabstrip_incognito_switch_incognito_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabstrip_incognito_switch_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabstrip_incognito_switch_normal_active.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/btn_incognito_tabs.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/btn_normal_tabs.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/tab_close_white.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/tab_close_white_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/tabstrip_incognito_switch_incognito.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/tabstrip_incognito_switch_incognito_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/tabstrip_incognito_switch_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/tabstrip_incognito_switch_normal_active.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_tab_close.xml View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/java/res/drawable/btn_tabstrip_incognito_switch.xml View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/java/res/drawable/btn_tabstrip_incognito_switch_incognito.xml View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/android/java/res/layout/accessibility_tab_switcher.xml View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aurimas (slooooooooow)
newt: PTAL The question about if we can use the different close (x) button is ...
5 years, 10 months ago (2015-02-04 00:52:02 UTC) #2
aurimas (slooooooooow)
Close icon change approved by sgabriel@. We are good to go!
5 years, 10 months ago (2015-02-04 03:05:07 UTC) #3
newt (away)
lgtm
5 years, 10 months ago (2015-02-04 21:36:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894453004/20001
5 years, 10 months ago (2015-02-04 21:38:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 21:59:09 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 22:00:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be606d08268052fd205d27c873a9baffe3b0d6d7
Cr-Commit-Position: refs/heads/master@{#314650}

Powered by Google App Engine
This is Rietveld 408576698