Source/core/layout/LayoutThemeChromiumDefault.h - Issue 894393003: Constify and use reference for RenderStyle in LayoutTheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutThemeChromiumDefault.h

Issue 894393003: Constify and use reference for RenderStyle in LayoutTheme (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/LayoutTheme.cpp ('K') | « Source/core/layout/LayoutThemeChromiumAndroid.cpp ('k') | Source/core/layout/LayoutThemeChromiumDefault.cpp » ('j') | Source/core/layout/LayoutThemeChromiumMac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutThemeChromiumDefault.h

diff --git a/Source/core/layout/LayoutThemeChromiumDefault.h b/Source/core/layout/LayoutThemeChromiumDefault.h

index 3ea132c4e3dd7c65b0be39b087d78be2ad552de3..b870aa71e2c0bc3d98d55a653557c48bf0735c12 100644

--- a/Source/core/layout/LayoutThemeChromiumDefault.h

+++ b/Source/core/layout/LayoutThemeChromiumDefault.h

@@ -39,7 +39,7 @@ public:

virtual Color systemColor(CSSValueID) const override;

- virtual bool supportsFocusRing(const RenderStyle*) const override;

+ virtual bool supportsFocusRing(const RenderStyle&) const override;

// List Box selection color

virtual Color activeListBoxSelectionBackgroundColor() const;

@@ -54,16 +54,16 @@ public:

virtual IntSize sliderTickSize() const override;

virtual int sliderTickOffsetFromTrackCenter() const override;

- virtual void adjustSliderThumbSize(RenderStyle*, Element*) const override;

+ virtual void adjustSliderThumbSize(RenderStyle&, Element*) const override;

static void setCaretBlinkInterval(double);

virtual double caretBlinkIntervalInternal() const override;

virtual bool paintCheckbox(RenderObject*, const PaintInfo&, const IntRect&) override;

- virtual void setCheckboxSize(RenderStyle*) const override;

+ virtual void setCheckboxSize(RenderStyle&) const override;

virtual bool paintRadio(RenderObject*, const PaintInfo&, const IntRect&) override;

- virtual void setRadioSize(RenderStyle*) const override;

+ virtual void setRadioSize(RenderStyle&) const override;

virtual bool paintButton(RenderObject*, const PaintInfo&, const IntRect&) override;

virtual bool paintTextField(RenderObject*, const PaintInfo&, const IntRect&) override;

@@ -72,7 +72,7 @@ public:

virtual bool paintSliderTrack(RenderObject*, const PaintInfo&, const IntRect&) override;

virtual bool paintSliderThumb(RenderObject*, const PaintInfo&, const IntRect&) override;

- virtual void adjustInnerSpinButtonStyle(RenderStyle*, Element*) const override;

+ virtual void adjustInnerSpinButtonStyle(RenderStyle&, Element*) const override;

virtual bool paintInnerSpinButton(RenderObject*, const PaintInfo&, const IntRect&) override;

virtual bool popsMenuBySpaceKey() const override final { return true; }

@@ -88,7 +88,7 @@ public:

protected:

LayoutThemeChromiumDefault();

virtual ~LayoutThemeChromiumDefault();

- virtual bool shouldUseFallbackTheme(RenderStyle*) const override;

+ virtual bool shouldUseFallbackTheme(const RenderStyle&) const override;

private:

static double m_caretBlinkInterval;