Constify and use reference for RenderStyle in LayoutTheme

Source/core/layout/LayoutThemeChromiumSkia.cpp

 /*
  * Copyright (C) 2007 Apple Inc.
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Collabora Ltd.
  * Copyright (C) 2008, 2009 Google Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 62 matching lines @@
         loadResourceAsASCIIString("themeWin.css") +
         loadResourceAsASCIIString("themeChromiumSkia.css") +
         loadResourceAsASCIIString("themeChromium.css");
 }
 
 String LayoutThemeChromiumSkia::extraQuirksStyleSheet()
 {
     return loadResourceAsASCIIString("themeWinQuirks.css");
 }
 
-bool LayoutThemeChromiumSkia::supportsHover(const RenderStyle* style) const
+bool LayoutThemeChromiumSkia::supportsHover(const RenderStyle& style) const
 {
     return true;
 }
 
-bool LayoutThemeChromiumSkia::supportsFocusRing(const RenderStyle* style) const
+bool LayoutThemeChromiumSkia::supportsFocusRing(const RenderStyle& style) const
 {
     // This causes WebKit to draw the focus rings for us.
     return false;
 }
 
 Color LayoutThemeChromiumSkia::platformActiveSelectionBackgroundColor() const
 {
     return Color(0x1e, 0x90, 0xff);
 }
 
@@ skipping 26 matching lines @@
         return 0;
 
     return caretBlinkIntervalInternal();
 }
 
 void LayoutThemeChromiumSkia::systemFont(CSSValueID systemFontID, FontStyle& fontStyle, FontWeight& fontWeight, float& fontSize, AtomicString& fontFamily) const
 {
     LayoutThemeChromiumFontProvider::systemFont(systemFontID, fontStyle, fontWeight, fontSize, fontFamily);
 }
 
-int LayoutThemeChromiumSkia::minimumMenuListSize(RenderStyle* style) const
+int LayoutThemeChromiumSkia::minimumMenuListSize(const RenderStyle& style) const
 {
     return 0;
 }
 
 // These are the default dimensions of radio buttons and checkboxes.
 static const int widgetStandardWidth = 13;
 static const int widgetStandardHeight = 13;
 
 // Return a rectangle that has the same center point as |original|, but with a
 // size capped at |width| by |height|.
 IntRect center(const IntRect& original, int width, int height)
 {
     width = std::min(original.width(), width);
     height = std::min(original.height(), height);
     int x = original.x() + (original.width() - width) / 2;
     int y = original.y() + (original.height() - height) / 2;
 
     return IntRect(x, y, width, height);
 }
 
-void LayoutThemeChromiumSkia::setCheckboxSize(RenderStyle* style) const
+void LayoutThemeChromiumSkia::setCheckboxSize(RenderStyle& style) const
 {
     // If the width and height are both specified, then we have nothing to do.
-    if (!style->width().isIntrinsicOrAuto() && !style->height().isAuto())
+    if (!style.width().isIntrinsicOrAuto() && !style.height().isAuto())
         return;
 
     // FIXME:  A hard-coded size of 13 is used.  This is wrong but necessary
     // for now.  It matches Firefox.  At different DPI settings on Windows,
     // querying the theme gives you a larger size that accounts for the higher
     // DPI.  Until our entire engine honors a DPI setting other than 96, we
     // can't rely on the theme's metrics.
     const IntSize size(widgetStandardWidth, widgetStandardHeight);
     setSizeIfAuto(style, size);
 }
 
-void LayoutThemeChromiumSkia::setRadioSize(RenderStyle* style) const
+void LayoutThemeChromiumSkia::setRadioSize(RenderStyle& style) const
 {
     // Use same sizing for radio box as checkbox.
     setCheckboxSize(style);
 }
 
-void LayoutThemeChromiumSkia::adjustButtonStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustButtonStyle(RenderStyle& style, Element*) const
 {
-    if (style->appearance() == PushButtonPart) {
+    if (style.appearance() == PushButtonPart) {
         // Ignore line-height.
-        style->setLineHeight(RenderStyle::initialLineHeight());
+        style.setLineHeight(RenderStyle::initialLineHeight());
     }
 }
 
 bool LayoutThemeChromiumSkia::paintTextArea(RenderObject* o, const PaintInfo& i, const IntRect& r)
 {
     return paintTextField(o, i, r);
 }
 
-void LayoutThemeChromiumSkia::adjustSearchFieldStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustSearchFieldStyle(RenderStyle& style, Element*) const
 {
     // Ignore line-height.
-    style->setLineHeight(RenderStyle::initialLineHeight());
+    style.setLineHeight(RenderStyle::initialLineHeight());
 }
 
 bool LayoutThemeChromiumSkia::paintSearchField(RenderObject* o, const PaintInfo& i, const IntRect& r)
 {
     return paintTextField(o, i, r);
 }
 
-void LayoutThemeChromiumSkia::adjustSearchFieldCancelButtonStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustSearchFieldCancelButtonStyle(RenderStyle& style, Element*) const
 {
     // Scale the button size based on the font size
-    float fontScale = style->fontSize() / defaultControlFontPixelSize;
+    float fontScale = style.fontSize() / defaultControlFontPixelSize;
     int cancelButtonSize = lroundf(std::min(std::max(minCancelButtonSize, defaultCancelButtonSize * fontScale), maxCancelButtonSize));
-    style->setWidth(Length(cancelButtonSize, Fixed));
-    style->setHeight(Length(cancelButtonSize, Fixed));
+    style.setWidth(Length(cancelButtonSize, Fixed));
+    style.setHeight(Length(cancelButtonSize, Fixed));
 }
 
 IntRect LayoutThemeChromiumSkia::convertToPaintingRect(RenderObject* inputRenderer, const RenderObject* partRenderer, LayoutRect partRect, const IntRect& localOffset) const
 {
     // Compute an offset between the part renderer and the input renderer.
     LayoutSize offsetFromInputRenderer = -partRenderer->offsetFromAncestorContainer(inputRenderer);
     // Move the rect into partRenderer's coords.
     partRect.move(offsetFromInputRenderer);
     // Account for the local drawing offset.
     partRect.move(localOffset.x(), localOffset.y());
@@ skipping 22 matching lines @@
         inputContentBox.y() + (inputContentBox.height() - cancelButtonSize + 1) / 2,
         cancelButtonSize, cancelButtonSize);
     IntRect paintingRect = convertToPaintingRect(inputRenderBox, cancelButtonObject, cancelButtonRect, r);
 
     DEFINE_STATIC_REF(Image, cancelImage, (Image::loadPlatformResource("searchCancel")));
     DEFINE_STATIC_REF(Image, cancelPressedImage, (Image::loadPlatformResource("searchCancelPressed")));
     paintInfo.context->drawImage(isPressed(cancelButtonObject) ? cancelPressedImage : cancelImage, paintingRect);
     return false;
 }
 
-void LayoutThemeChromiumSkia::adjustSearchFieldDecorationStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustSearchFieldDecorationStyle(RenderStyle& style, Element*) const
 {
     IntSize emptySize(1, 11);
-    style->setWidth(Length(emptySize.width(), Fixed));
-    style->setHeight(Length(emptySize.height(), Fixed));
+    style.setWidth(Length(emptySize.width(), Fixed));
+    style.setHeight(Length(emptySize.height(), Fixed));
 }
 
-void LayoutThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle(RenderStyle& style, Element*) const
 {
     // Scale the decoration size based on the font size
-    float fontScale = style->fontSize() / defaultControlFontPixelSize;
+    float fontScale = style.fontSize() / defaultControlFontPixelSize;
     int magnifierSize = lroundf(std::min(std::max(minSearchFieldResultsDecorationSize, defaultSearchFieldResultsDecorationSize * fontScale),
         maxSearchFieldResultsDecorationSize));
-    style->setWidth(Length(magnifierSize, Fixed));
-    style->setHeight(Length(magnifierSize, Fixed));
+    style.setWidth(Length(magnifierSize, Fixed));
+    style.setHeight(Length(magnifierSize, Fixed));
 }
 
 bool LayoutThemeChromiumSkia::paintSearchFieldResultsDecoration(RenderObject* magnifierObject, const PaintInfo& paintInfo, const IntRect& r)
 {
     // Get the renderer of <input> element.
     if (!magnifierObject->node())
         return false;
     Node* input = magnifierObject->node()->shadowHost();
     RenderObject* baseRenderer = input ? input->renderer() : magnifierObject;
     if (!baseRenderer->isBox())
@@ skipping 19 matching lines @@
 bool LayoutThemeChromiumSkia::paintMediaSliderTrack(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
 {
     return RenderMediaControls::paintMediaControlsPart(MediaSlider, object, paintInfo, rect);
 }
 
 bool LayoutThemeChromiumSkia::paintMediaVolumeSliderTrack(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
 {
     return RenderMediaControls::paintMediaControlsPart(MediaVolumeSlider, object, paintInfo, rect);
 }
 
-void LayoutThemeChromiumSkia::adjustSliderThumbSize(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustSliderThumbSize(RenderStyle& style, Element*) const
 {
     RenderMediaControls::adjustMediaSliderThumbSize(style);
 }
 
 bool LayoutThemeChromiumSkia::paintMediaSliderThumb(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
 {
     return RenderMediaControls::paintMediaControlsPart(MediaSliderThumb, object, paintInfo, rect);
 }
 
 bool LayoutThemeChromiumSkia::paintMediaToggleClosedCaptionsButton(RenderObject* o, const PaintInfo& paintInfo, const IntRect& r)
@@ skipping 34 matching lines @@
 String LayoutThemeChromiumSkia::formatMediaControlsCurrentTime(float currentTime, float duration) const
 {
     return RenderMediaControls::formatMediaControlsCurrentTime(currentTime, duration);
 }
 
 bool LayoutThemeChromiumSkia::paintMediaFullscreenButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
 {
     return RenderMediaControls::paintMediaControlsPart(MediaEnterFullscreenButton, object, paintInfo, rect);
 }
 
-void LayoutThemeChromiumSkia::adjustMenuListStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumSkia::adjustMenuListStyle(RenderStyle& style, Element*) const
 {
     // Height is locked to auto on all browsers.
-    style->setLineHeight(RenderStyle::initialLineHeight());
+    style.setLineHeight(RenderStyle::initialLineHeight());
 }
 
-void LayoutThemeChromiumSkia::adjustMenuListButtonStyle(RenderStyle* style, Element* e) const
+void LayoutThemeChromiumSkia::adjustMenuListButtonStyle(RenderStyle& style, Element* e) const
 {
     adjustMenuListStyle(style, e);
 }
 
 // Used to paint styled menulists (i.e. with a non-default border)
 bool LayoutThemeChromiumSkia::paintMenuListButton(RenderObject* o, const PaintInfo& i, const IntRect& rect)
 {
     return paintMenuList(o, i, rect);
 }
 
-int LayoutThemeChromiumSkia::popupInternalPaddingLeft(RenderStyle* style) const
+int LayoutThemeChromiumSkia::popupInternalPaddingLeft(const RenderStyle& style) const
 {
     return menuListInternalPadding(style, LeftPadding);
 }
 
-int LayoutThemeChromiumSkia::popupInternalPaddingRight(RenderStyle* style) const
+int LayoutThemeChromiumSkia::popupInternalPaddingRight(const RenderStyle& style) const
 {
     return menuListInternalPadding(style, RightPadding);
 }
 
-int LayoutThemeChromiumSkia::popupInternalPaddingTop(RenderStyle* style) const
+int LayoutThemeChromiumSkia::popupInternalPaddingTop(const RenderStyle& style) const
 {
     return menuListInternalPadding(style, TopPadding);
 }
 
-int LayoutThemeChromiumSkia::popupInternalPaddingBottom(RenderStyle* style) const
+int LayoutThemeChromiumSkia::popupInternalPaddingBottom(const RenderStyle& style) const
 {
     return menuListInternalPadding(style, BottomPadding);
 }
 
 // static
 void LayoutThemeChromiumSkia::setDefaultFontSize(int fontSize)
 {
     LayoutThemeChromiumFontProvider::setDefaultFontSize(fontSize);
 }
 
 double LayoutThemeChromiumSkia::caretBlinkIntervalInternal() const
 {
     return LayoutTheme::caretBlinkInterval();
 }
 
 int LayoutThemeChromiumSkia::menuListArrowPadding() const
 {
     return ScrollbarTheme::theme()->scrollbarThickness();
 }
 
-int LayoutThemeChromiumSkia::menuListInternalPadding(RenderStyle* style, int paddingType) const
+int LayoutThemeChromiumSkia::menuListInternalPadding(const RenderStyle& style, int paddingType) const
 {
     // This internal padding is in addition to the user-supplied padding.
     // Matches the FF behavior.
     int padding = styledMenuListInternalPadding[paddingType];
 
     // Reserve the space for right arrow here. The rest of the padding is
     // set by adjustMenuListStyle, since PopMenuWin.cpp uses the padding from
     // RenderMenuList to lay out the individual items in the popup.
     // If the MenuList actually has appearance "NoAppearance", then that means
     // we don't draw a button, so don't reserve space for it.
-    const int barType = style->direction() == LTR ? RightPadding : LeftPadding;
-    if (paddingType == barType && style->appearance() != NoControlPart)
+    const int barType = style.direction() == LTR ? RightPadding : LeftPadding;
+    if (paddingType == barType && style.appearance() != NoControlPart)
         padding += menuListArrowPadding();
 
     return padding;
 }
 
 bool LayoutThemeChromiumSkia::shouldShowPlaceholderWhenFocused() const
 {
     return true;
 }
 
@@ skipping 51 matching lines @@
 }
 
 LayoutThemeChromiumSkia::DirectionFlippingScope::~DirectionFlippingScope()
 {
     if (!m_needsFlipping)
         return;
     m_paintInfo.context->restore();
 }
 
 } // namespace blink