Constify and use reference for RenderStyle in LayoutTheme

Source/core/layout/LayoutThemeChromiumDefault.cpp

 /*
  * Copyright (C) 2007 Apple Inc.
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Collabora Ltd.
  * Copyright (C) 2008, 2009 Google Inc.
  * Copyright (C) 2009 Kenneth Rohde Christiansen
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 66 matching lines @@
 
 LayoutThemeChromiumDefault::LayoutThemeChromiumDefault()
 {
     m_caretBlinkInterval = LayoutTheme::caretBlinkInterval();
 }
 
 LayoutThemeChromiumDefault::~LayoutThemeChromiumDefault()
 {
 }
 
-bool LayoutThemeChromiumDefault::supportsFocusRing(const RenderStyle* style) const
+bool LayoutThemeChromiumDefault::supportsFocusRing(const RenderStyle& style) const
 {
     if (useMockTheme()) {
         // Don't use focus rings for buttons when mocking controls.
-        return style->appearance() == ButtonPart
-            || style->appearance() == PushButtonPart
-            || style->appearance() == SquareButtonPart;
+        return style.appearance() == ButtonPart
+            || style.appearance() == PushButtonPart
+            || style.appearance() == SquareButtonPart;
     }
 
     return LayoutThemeChromiumSkia::supportsFocusRing(style);
 }
 
 Color LayoutThemeChromiumDefault::systemColor(CSSValueID cssValueId) const
 {
     static const Color defaultButtonGrayColor(0xffdddddd);
     static const Color defaultMenuColor(0xfff7f7f7);
 
@@ skipping 72 matching lines @@
     return IntSize(1, 6);
 }
 
 int LayoutThemeChromiumDefault::sliderTickOffsetFromTrackCenter() const
 {
     if (useMockTheme())
         return 11;
     return -16;
 }
 
-void LayoutThemeChromiumDefault::adjustSliderThumbSize(RenderStyle* style, Element* element) const
+void LayoutThemeChromiumDefault::adjustSliderThumbSize(RenderStyle& style, Element* element) const
 {
     IntSize size = Platform::current()->themeEngine()->getSize(WebThemeEngine::PartSliderThumb);
 
     // FIXME: Mock theme doesn't handle zoomed sliders.
-    float zoomLevel = useMockTheme() ? 1 : style->effectiveZoom();
-    if (style->appearance() == SliderThumbHorizontalPart) {
-        style->setWidth(Length(size.width() * zoomLevel, Fixed));
-        style->setHeight(Length(size.height() * zoomLevel, Fixed));
-    } else if (style->appearance() == SliderThumbVerticalPart) {
-        style->setWidth(Length(size.height() * zoomLevel, Fixed));
-        style->setHeight(Length(size.width() * zoomLevel, Fixed));
+    float zoomLevel = useMockTheme() ? 1 : style.effectiveZoom();
+    if (style.appearance() == SliderThumbHorizontalPart) {
+        style.setWidth(Length(size.width() * zoomLevel, Fixed));
+        style.setHeight(Length(size.height() * zoomLevel, Fixed));
+    } else if (style.appearance() == SliderThumbVerticalPart) {
+        style.setWidth(Length(size.height() * zoomLevel, Fixed));
+        style.setHeight(Length(size.width() * zoomLevel, Fixed));
     } else {
         LayoutThemeChromiumSkia::adjustSliderThumbSize(style, element);
     }
 }
 
 void LayoutThemeChromiumDefault::setCaretBlinkInterval(double interval)
 {
     m_caretBlinkInterval = interval;
 }
 
@@ skipping 30 matching lines @@
         unzoomedRect.setHeight(unzoomedRect.height() / zoomLevel);
         i.context->translate(unzoomedRect.x(), unzoomedRect.y());
         i.context->scale(zoomLevel, zoomLevel);
         i.context->translate(-unzoomedRect.x(), -unzoomedRect.y());
     }
 
     Platform::current()->themeEngine()->paint(canvas, WebThemeEngine::PartCheckbox, getWebThemeState(this, o), WebRect(unzoomedRect), &extraParams);
     return false;
 }
 
-void LayoutThemeChromiumDefault::setCheckboxSize(RenderStyle* style) const
+void LayoutThemeChromiumDefault::setCheckboxSize(RenderStyle& style) const
 {
     // If the width and height are both specified, then we have nothing to do.
-    if (!style->width().isIntrinsicOrAuto() && !style->height().isAuto())
+    if (!style.width().isIntrinsicOrAuto() && !style.height().isAuto())
         return;
 
     IntSize size = Platform::current()->themeEngine()->getSize(WebThemeEngine::PartCheckbox);
-    float zoomLevel = style->effectiveZoom();
+    float zoomLevel = style.effectiveZoom();
     size.setWidth(size.width() * zoomLevel);
     size.setHeight(size.height() * zoomLevel);
     setSizeIfAuto(style, size);
 }
 
 bool LayoutThemeChromiumDefault::paintRadio(RenderObject* o, const PaintInfo& i, const IntRect& rect)
 {
     WebThemeEngine::ExtraParams extraParams;
     WebCanvas* canvas = i.context->canvas();
     extraParams.button.checked = isChecked(o);
 
     Platform::current()->themeEngine()->paint(canvas, WebThemeEngine::PartRadio, getWebThemeState(this, o), WebRect(rect), &extraParams);
     return false;
 }
 
-void LayoutThemeChromiumDefault::setRadioSize(RenderStyle* style) const
+void LayoutThemeChromiumDefault::setRadioSize(RenderStyle& style) const
 {
     // If the width and height are both specified, then we have nothing to do.
-    if (!style->width().isIntrinsicOrAuto() && !style->height().isAuto())
+    if (!style.width().isIntrinsicOrAuto() && !style.height().isAuto())
         return;
 
     IntSize size = Platform::current()->themeEngine()->getSize(WebThemeEngine::PartRadio);
-    float zoomLevel = style->effectiveZoom();
+    float zoomLevel = style.effectiveZoom();
     size.setWidth(size.width() * zoomLevel);
     size.setHeight(size.height() * zoomLevel);
     setSizeIfAuto(style, size);
 }
 
 bool LayoutThemeChromiumDefault::paintButton(RenderObject* o, const PaintInfo& i, const IntRect& rect)
 {
     WebThemeEngine::ExtraParams extraParams;
     WebCanvas* canvas = i.context->canvas();
     extraParams.button.hasBorder = true;
@@ skipping 149 matching lines @@
         unzoomedRect.setHeight(unzoomedRect.height() / zoomLevel);
         i.context->translate(unzoomedRect.x(), unzoomedRect.y());
         i.context->scale(zoomLevel, zoomLevel);
         i.context->translate(-unzoomedRect.x(), -unzoomedRect.y());
     }
 
     Platform::current()->themeEngine()->paint(canvas, WebThemeEngine::PartSliderThumb, getWebThemeState(this, o), WebRect(unzoomedRect), &extraParams);
     return false;
 }
 
-void LayoutThemeChromiumDefault::adjustInnerSpinButtonStyle(RenderStyle* style, Element*) const
+void LayoutThemeChromiumDefault::adjustInnerSpinButtonStyle(RenderStyle& style, Element*) const
 {
     IntSize size = Platform::current()->themeEngine()->getSize(WebThemeEngine::PartInnerSpinButton);
 
-    style->setWidth(Length(size.width(), Fixed));
-    style->setMinWidth(Length(size.width(), Fixed));
+    style.setWidth(Length(size.width(), Fixed));
+    style.setMinWidth(Length(size.width(), Fixed));
 }
 
 bool LayoutThemeChromiumDefault::paintInnerSpinButton(RenderObject* o, const PaintInfo& i, const IntRect& rect)
 {
     WebThemeEngine::ExtraParams extraParams;
     WebCanvas* canvas = i.context->canvas();
     extraParams.innerSpin.spinUp = (controlStatesForRenderer(o) & SpinUpControlState);
     extraParams.innerSpin.readOnly = isReadOnlyControl(o);
 
     Platform::current()->themeEngine()->paint(canvas, WebThemeEngine::PartInnerSpinButton, getWebThemeState(this, o), WebRect(rect), &extraParams);
@@ skipping 19 matching lines @@
     WebCanvas* canvas = i.context->canvas();
     Platform::current()->themeEngine()->paint(canvas, WebThemeEngine::PartProgressBar, getWebThemeState(this, o), WebRect(rect), &extraParams);
     return false;
 }
 
 bool LayoutThemeChromiumDefault::shouldOpenPickerWithF4Key() const
 {
     return true;
 }
 
-bool LayoutThemeChromiumDefault::shouldUseFallbackTheme(RenderStyle* style) const
+bool LayoutThemeChromiumDefault::shouldUseFallbackTheme(const RenderStyle& style) const
 {
     if (useMockTheme()) {
         // The mock theme can't handle zoomed controls, so we fall back to the "fallback" theme.
-        ControlPart part = style->appearance();
+        ControlPart part = style.appearance();
         if (part == CheckboxPart || part == RadioPart)
-            return style->effectiveZoom() != 1;
+            return style.effectiveZoom() != 1;
     }
     return LayoutTheme::shouldUseFallbackTheme(style);
 }
 
 } // namespace blink